test: increase test coverage for listings, auth, and search modules
Add 33 new test files to reach coverage targets: - Listings: 13 → 28 test files (50%+) - Auth: 21 → 36 test files (50%+) - Search: 10 → 13 test files (59%+) New tests cover domain entities, value objects, services, guards, decorators, DTOs, repositories, controllers, and event handlers. Total: 204 test files, 1178 tests passing. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -0,0 +1,68 @@
|
||||
import { describe, it, expect } from 'vitest';
|
||||
import { GeoFilter } from '../value-objects/geo-filter.vo';
|
||||
|
||||
describe('GeoFilter', () => {
|
||||
it('creates filter with all properties', () => {
|
||||
const filter = GeoFilter.create({
|
||||
lat: 10.7769,
|
||||
lng: 106.7009,
|
||||
radiusKm: 5,
|
||||
propertyType: 'APARTMENT',
|
||||
transactionType: 'RENT',
|
||||
priceMin: 5_000_000,
|
||||
priceMax: 20_000_000,
|
||||
sortBy: 'price_asc',
|
||||
page: 3,
|
||||
perPage: 25,
|
||||
});
|
||||
|
||||
expect(filter.lat).toBe(10.7769);
|
||||
expect(filter.lng).toBe(106.7009);
|
||||
expect(filter.radiusKm).toBe(5);
|
||||
expect(filter.propertyType).toBe('APARTMENT');
|
||||
expect(filter.transactionType).toBe('RENT');
|
||||
expect(filter.priceMin).toBe(5_000_000);
|
||||
expect(filter.priceMax).toBe(20_000_000);
|
||||
expect(filter.sortBy).toBe('price_asc');
|
||||
expect(filter.page).toBe(3);
|
||||
expect(filter.perPage).toBe(25);
|
||||
});
|
||||
|
||||
it('applies default sortBy as distance', () => {
|
||||
const filter = GeoFilter.create({ lat: 10.7, lng: 106.7, radiusKm: 5 });
|
||||
expect(filter.sortBy).toBe('distance');
|
||||
});
|
||||
|
||||
it('applies default page as 1', () => {
|
||||
const filter = GeoFilter.create({ lat: 10.7, lng: 106.7, radiusKm: 5 });
|
||||
expect(filter.page).toBe(1);
|
||||
});
|
||||
|
||||
it('applies default perPage as 20', () => {
|
||||
const filter = GeoFilter.create({ lat: 10.7, lng: 106.7, radiusKm: 5 });
|
||||
expect(filter.perPage).toBe(20);
|
||||
});
|
||||
|
||||
it('caps radiusKm at 100', () => {
|
||||
const filter = GeoFilter.create({ lat: 10.7, lng: 106.7, radiusKm: 200 });
|
||||
expect(filter.radiusKm).toBe(100);
|
||||
});
|
||||
|
||||
it('does not cap radiusKm when under 100', () => {
|
||||
const filter = GeoFilter.create({ lat: 10.7, lng: 106.7, radiusKm: 50 });
|
||||
expect(filter.radiusKm).toBe(50);
|
||||
});
|
||||
|
||||
it('caps perPage at 100', () => {
|
||||
const filter = GeoFilter.create({ lat: 10.7, lng: 106.7, radiusKm: 5, perPage: 500 });
|
||||
expect(filter.perPage).toBe(100);
|
||||
});
|
||||
|
||||
it('returns undefined for unset optional properties', () => {
|
||||
const filter = GeoFilter.create({ lat: 10.7, lng: 106.7, radiusKm: 5 });
|
||||
expect(filter.propertyType).toBeUndefined();
|
||||
expect(filter.transactionType).toBeUndefined();
|
||||
expect(filter.priceMin).toBeUndefined();
|
||||
expect(filter.priceMax).toBeUndefined();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,75 @@
|
||||
import { describe, it, expect } from 'vitest';
|
||||
import { SearchFilter } from '../value-objects/search-filter.vo';
|
||||
|
||||
describe('SearchFilter', () => {
|
||||
it('creates filter with all properties', () => {
|
||||
const filter = SearchFilter.create({
|
||||
query: 'căn hộ quận 7',
|
||||
propertyType: 'APARTMENT',
|
||||
transactionType: 'SALE',
|
||||
priceMin: 2_000_000_000,
|
||||
priceMax: 8_000_000_000,
|
||||
areaMin: 60,
|
||||
areaMax: 150,
|
||||
bedrooms: 2,
|
||||
district: 'Quận 7',
|
||||
city: 'Hồ Chí Minh',
|
||||
sortBy: 'price_desc',
|
||||
page: 4,
|
||||
perPage: 30,
|
||||
});
|
||||
|
||||
expect(filter.query).toBe('căn hộ quận 7');
|
||||
expect(filter.propertyType).toBe('APARTMENT');
|
||||
expect(filter.transactionType).toBe('SALE');
|
||||
expect(filter.priceMin).toBe(2_000_000_000);
|
||||
expect(filter.priceMax).toBe(8_000_000_000);
|
||||
expect(filter.areaMin).toBe(60);
|
||||
expect(filter.areaMax).toBe(150);
|
||||
expect(filter.bedrooms).toBe(2);
|
||||
expect(filter.district).toBe('Quận 7');
|
||||
expect(filter.city).toBe('Hồ Chí Minh');
|
||||
expect(filter.sortBy).toBe('price_desc');
|
||||
expect(filter.page).toBe(4);
|
||||
expect(filter.perPage).toBe(30);
|
||||
});
|
||||
|
||||
it('applies default sortBy as relevance', () => {
|
||||
const filter = SearchFilter.create({});
|
||||
expect(filter.sortBy).toBe('relevance');
|
||||
});
|
||||
|
||||
it('applies default page as 1', () => {
|
||||
const filter = SearchFilter.create({});
|
||||
expect(filter.page).toBe(1);
|
||||
});
|
||||
|
||||
it('applies default perPage as 20', () => {
|
||||
const filter = SearchFilter.create({});
|
||||
expect(filter.perPage).toBe(20);
|
||||
});
|
||||
|
||||
it('caps perPage at 100', () => {
|
||||
const filter = SearchFilter.create({ perPage: 250 });
|
||||
expect(filter.perPage).toBe(100);
|
||||
});
|
||||
|
||||
it('returns undefined for unset optional properties', () => {
|
||||
const filter = SearchFilter.create({});
|
||||
expect(filter.query).toBeUndefined();
|
||||
expect(filter.propertyType).toBeUndefined();
|
||||
expect(filter.transactionType).toBeUndefined();
|
||||
expect(filter.priceMin).toBeUndefined();
|
||||
expect(filter.priceMax).toBeUndefined();
|
||||
expect(filter.areaMin).toBeUndefined();
|
||||
expect(filter.areaMax).toBeUndefined();
|
||||
expect(filter.bedrooms).toBeUndefined();
|
||||
expect(filter.district).toBeUndefined();
|
||||
expect(filter.city).toBeUndefined();
|
||||
});
|
||||
|
||||
it('handles empty query string', () => {
|
||||
const filter = SearchFilter.create({ query: '' });
|
||||
expect(filter.query).toBe('');
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,131 @@
|
||||
import { CachePrefix, CacheService } from '@modules/shared/infrastructure/cache.service';
|
||||
import { ListingStatusChangedHandler } from '../event-handlers/listing-status-changed.handler';
|
||||
|
||||
describe('ListingStatusChangedHandler', () => {
|
||||
let handler: ListingStatusChangedHandler;
|
||||
let mockIndexer: { indexListing: ReturnType<typeof vi.fn>; removeListing: ReturnType<typeof vi.fn> };
|
||||
let mockCache: {
|
||||
invalidate: ReturnType<typeof vi.fn>;
|
||||
invalidateByPrefix: ReturnType<typeof vi.fn>;
|
||||
};
|
||||
let mockLogger: { log: ReturnType<typeof vi.fn>; warn: ReturnType<typeof vi.fn>; error: ReturnType<typeof vi.fn> };
|
||||
|
||||
beforeEach(() => {
|
||||
mockIndexer = {
|
||||
indexListing: vi.fn().mockResolvedValue(undefined),
|
||||
removeListing: vi.fn().mockResolvedValue(undefined),
|
||||
};
|
||||
mockCache = {
|
||||
invalidate: vi.fn().mockResolvedValue(undefined),
|
||||
invalidateByPrefix: vi.fn().mockResolvedValue(undefined),
|
||||
};
|
||||
mockLogger = {
|
||||
log: vi.fn(),
|
||||
warn: vi.fn(),
|
||||
error: vi.fn(),
|
||||
};
|
||||
handler = new ListingStatusChangedHandler(mockIndexer as any, mockCache as any, mockLogger as any);
|
||||
});
|
||||
|
||||
it('removes listing from index when status changed to REJECTED', async () => {
|
||||
await handler.handle({
|
||||
aggregateId: 'listing-1',
|
||||
propertyId: 'prop-1',
|
||||
previousStatus: 'ACTIVE',
|
||||
newStatus: 'REJECTED',
|
||||
eventName: 'listing.status_changed',
|
||||
occurredAt: new Date(),
|
||||
} as any);
|
||||
|
||||
expect(mockIndexer.removeListing).toHaveBeenCalledWith('listing-1');
|
||||
});
|
||||
|
||||
it('removes listing from index when status changed to EXPIRED', async () => {
|
||||
await handler.handle({
|
||||
aggregateId: 'listing-2',
|
||||
propertyId: 'prop-2',
|
||||
previousStatus: 'ACTIVE',
|
||||
newStatus: 'EXPIRED',
|
||||
eventName: 'listing.status_changed',
|
||||
occurredAt: new Date(),
|
||||
} as any);
|
||||
|
||||
expect(mockIndexer.removeListing).toHaveBeenCalledWith('listing-2');
|
||||
});
|
||||
|
||||
it('removes listing from index when status changed to SOLD', async () => {
|
||||
await handler.handle({
|
||||
aggregateId: 'listing-3',
|
||||
propertyId: 'prop-3',
|
||||
previousStatus: 'ACTIVE',
|
||||
newStatus: 'SOLD',
|
||||
eventName: 'listing.status_changed',
|
||||
occurredAt: new Date(),
|
||||
} as any);
|
||||
|
||||
expect(mockIndexer.removeListing).toHaveBeenCalledWith('listing-3');
|
||||
});
|
||||
|
||||
it('removes listing from index when status changed to RENTED', async () => {
|
||||
await handler.handle({
|
||||
aggregateId: 'listing-4',
|
||||
propertyId: 'prop-4',
|
||||
previousStatus: 'ACTIVE',
|
||||
newStatus: 'RENTED',
|
||||
eventName: 'listing.status_changed',
|
||||
occurredAt: new Date(),
|
||||
} as any);
|
||||
|
||||
expect(mockIndexer.removeListing).toHaveBeenCalledWith('listing-4');
|
||||
});
|
||||
|
||||
it('does NOT remove listing from index when status changed to ACTIVE', async () => {
|
||||
await handler.handle({
|
||||
aggregateId: 'listing-5',
|
||||
propertyId: 'prop-5',
|
||||
previousStatus: 'PENDING_REVIEW',
|
||||
newStatus: 'ACTIVE',
|
||||
eventName: 'listing.status_changed',
|
||||
occurredAt: new Date(),
|
||||
} as any);
|
||||
|
||||
expect(mockIndexer.removeListing).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('invalidates listing cache, search cache, and geo search cache on any status change', async () => {
|
||||
await handler.handle({
|
||||
aggregateId: 'listing-6',
|
||||
propertyId: 'prop-6',
|
||||
previousStatus: 'DRAFT',
|
||||
newStatus: 'ACTIVE',
|
||||
eventName: 'listing.status_changed',
|
||||
occurredAt: new Date(),
|
||||
} as any);
|
||||
|
||||
expect(mockCache.invalidate).toHaveBeenCalledWith(
|
||||
CacheService.buildKey(CachePrefix.LISTING, 'listing-6'),
|
||||
);
|
||||
expect(mockCache.invalidateByPrefix).toHaveBeenCalledWith(CachePrefix.SEARCH);
|
||||
expect(mockCache.invalidateByPrefix).toHaveBeenCalledWith(CachePrefix.GEO_SEARCH);
|
||||
});
|
||||
|
||||
it('logs the status transition', async () => {
|
||||
await handler.handle({
|
||||
aggregateId: 'listing-7',
|
||||
propertyId: 'prop-7',
|
||||
previousStatus: 'ACTIVE',
|
||||
newStatus: 'SOLD',
|
||||
eventName: 'listing.status_changed',
|
||||
occurredAt: new Date(),
|
||||
} as any);
|
||||
|
||||
expect(mockLogger.log).toHaveBeenCalledWith(
|
||||
expect.stringContaining('ACTIVE'),
|
||||
expect.any(String),
|
||||
);
|
||||
expect(mockLogger.log).toHaveBeenCalledWith(
|
||||
expect.stringContaining('SOLD'),
|
||||
expect.any(String),
|
||||
);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user