admin/goodgo-platform
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: production readiness — resolve build, lint, and code quality issues

Browse Source 
- Fix Next.js build failure: remove duplicate route at (dashboard)/listings/[id]
  that conflicted with (public)/listings/[id] (same URL path in two route groups)
- Fix 772 ESLint errors: auto-fix import ordering (import-x/order), remove unused
  imports/variables, convert empty interfaces to type aliases, replace require()
  with ESM imports, fix consistent-type-imports violations
- Add CLAUDE.md for developer onboarding documentation
- All checks pass: 0 lint errors, typecheck clean, 230 tests passing, build success

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Ho Ngoc Hai
2026-04-08 07:15:06 +07:00
parent afa70320f5
commit 2502aa69b7
239 changed files with 746 additions and 984 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/api/src/modules/notifications/application/__tests__/agent-verified.listener.spec.ts
View File

@@ -1,6 +1,6 @@
import { AgentVerifiedListener } from '../listeners/agent-verified.listener';
import { AgentVerifiedEvent } from '@modules/auth/domain/events/agent-verified.event';
import { SendNotificationCommand } from '../commands/send-notification/send-notification.command';
import { AgentVerifiedListener } from '../listeners/agent-verified.listener';
describe('AgentVerifiedListener', () => {
let listener: AgentVerifiedListener;

2
apps/api/src/modules/notifications/application/__tests__/send-notification.handler.spec.ts
View File

@@ -1,5 +1,5 @@
import { SendNotificationHandler } from '../commands/send-notification/send-notification.handler';
import { SendNotificationCommand } from '../commands/send-notification/send-notification.command';
import { SendNotificationHandler } from '../commands/send-notification/send-notification.handler';
describe('SendNotificationHandler', () => {
let handler: SendNotificationHandler;

2
apps/api/src/modules/notifications/application/__tests__/user-registered.listener.spec.ts
View File

@@ -1,6 +1,6 @@
import { UserRegisteredListener } from '../listeners/user-registered.listener';
import { UserRegisteredEvent } from '@modules/auth/domain/events/user-registered.event';
import { SendNotificationCommand } from '../commands/send-notification/send-notification.command';
import { UserRegisteredListener } from '../listeners/user-registered.listener';
describe('UserRegisteredListener', () => {
let listener: UserRegisteredListener;

24
apps/api/src/modules/notifications/application/commands/send-notification/send-notification.handler.ts
View File

@@ -1,20 +1,20 @@
import { CommandHandler, type ICommandHandler } from '@nestjs/cqrs';
import { Inject } from '@nestjs/common';
import { LoggerService } from '@modules/shared/infrastructure/logger.service';
import { EventBusService } from '@modules/shared/infrastructure/event-bus.service';
import { SendNotificationCommand } from './send-notification.command';
import {
NOTIFICATION_REPOSITORY,
type INotificationRepository,
} from '../../../domain/repositories/notification.repository';
import { CommandHandler, type ICommandHandler } from '@nestjs/cqrs';
import { type EventBusService } from '@modules/shared/infrastructure/event-bus.service';
import { type LoggerService } from '@modules/shared/infrastructure/logger.service';
import { NotificationSentEvent } from '../../../domain/events/notification-sent.event';
import {
NOTIFICATION_PREFERENCE_REPOSITORY,
type INotificationPreferenceRepository,
} from '../../../domain/repositories/notification-preference.repository';
import { NotificationSentEvent } from '../../../domain/events/notification-sent.event';
import { EmailService } from '../../../infrastructure/services/email.service';
import { FcmService } from '../../../infrastructure/services/fcm.service';
import { TemplateService } from '../../../infrastructure/services/template.service';
import {
NOTIFICATION_REPOSITORY,
type INotificationRepository,
} from '../../../domain/repositories/notification.repository';
import { type EmailService } from '../../../infrastructure/services/email.service';
import { type FcmService } from '../../../infrastructure/services/fcm.service';
import { type TemplateService } from '../../../infrastructure/services/template.service';
import { SendNotificationCommand } from './send-notification.command';
@CommandHandler(SendNotificationCommand)
export class SendNotificationHandler implements ICommandHandler<SendNotificationCommand> {

8
apps/api/src/modules/notifications/application/listeners/agent-verified.listener.ts
View File

@@ -1,9 +1,9 @@
import { Injectable } from '@nestjs/common';
import { type CommandBus } from '@nestjs/cqrs';
import { OnEvent } from '@nestjs/event-emitter';
import { CommandBus } from '@nestjs/cqrs';
import { PrismaService } from '@modules/shared/infrastructure/prisma.service';
import { LoggerService } from '@modules/shared/infrastructure/logger.service';
import { AgentVerifiedEvent } from '@modules/auth/domain/events/agent-verified.event';
import { type AgentVerifiedEvent } from '@modules/auth/domain/events/agent-verified.event';
import { type LoggerService } from '@modules/shared/infrastructure/logger.service';
import { type PrismaService } from '@modules/shared/infrastructure/prisma.service';
import { SendNotificationCommand } from '../commands/send-notification/send-notification.command';
@Injectable()

8
apps/api/src/modules/notifications/application/listeners/user-registered.listener.ts
View File

@@ -1,9 +1,9 @@
import { Injectable } from '@nestjs/common';
import { type CommandBus } from '@nestjs/cqrs';
import { OnEvent } from '@nestjs/event-emitter';
import { CommandBus } from '@nestjs/cqrs';
import { PrismaService } from '@modules/shared/infrastructure/prisma.service';
import { LoggerService } from '@modules/shared/infrastructure/logger.service';
import { UserRegisteredEvent } from '@modules/auth/domain/events/user-registered.event';
import { type UserRegisteredEvent } from '@modules/auth/domain/events/user-registered.event';
import { type LoggerService } from '@modules/shared/infrastructure/logger.service';
import { type PrismaService } from '@modules/shared/infrastructure/prisma.service';
import { SendNotificationCommand } from '../commands/send-notification/send-notification.command';
@Injectable()

2
apps/api/src/modules/notifications/domain/value-objects/notification-channel.vo.ts
View File

@@ -1,4 +1,4 @@
import { NotificationChannel as PrismaChannel } from '@prisma/client';
import { type NotificationChannel as PrismaChannel } from '@prisma/client';
export const NotificationChannel = {
EMAIL: 'EMAIL',

4
apps/api/src/modules/notifications/infrastructure/repositories/prisma-notification-preference.repository.ts
View File

@@ -1,7 +1,7 @@
import { Injectable } from '@nestjs/common';
import { PrismaService } from '@modules/shared/infrastructure/prisma.service';
import { type INotificationPreferenceRepository } from '../../domain/repositories/notification-preference.repository';
import { type PrismaService } from '@modules/shared/infrastructure/prisma.service';
import { type NotificationPreferenceEntity } from '../../domain/entities/notification-preference.entity';
import { type INotificationPreferenceRepository } from '../../domain/repositories/notification-preference.repository';
import { type NotificationChannel } from '../../domain/value-objects/notification-channel.vo';
@Injectable()

4
apps/api/src/modules/notifications/infrastructure/repositories/prisma-notification.repository.ts
View File

@@ -1,11 +1,11 @@
import { Injectable } from '@nestjs/common';
import { type Prisma } from '@prisma/client';
import { PrismaService } from '@modules/shared/infrastructure/prisma.service';
import { type PrismaService } from '@modules/shared/infrastructure/prisma.service';
import { type NotificationEntity, type NotificationStatus } from '../../domain/entities/notification.entity';
import {
type INotificationRepository,
type CreateNotificationDto,
} from '../../domain/repositories/notification.repository';
import { type NotificationEntity, type NotificationStatus } from '../../domain/entities/notification.entity';
@Injectable()
export class PrismaNotificationRepository implements INotificationRepository {

2
apps/api/src/modules/notifications/infrastructure/services/email.service.ts
View File

@@ -1,6 +1,6 @@
import { Injectable, type OnModuleInit } from '@nestjs/common';
import { LoggerService } from '@modules/shared/infrastructure/logger.service';
import * as nodemailer from 'nodemailer';
import { type LoggerService } from '@modules/shared/infrastructure/logger.service';
export interface SendEmailDto {
to: string;

18
apps/api/src/modules/notifications/infrastructure/services/fcm.service.ts
View File

@@ -1,6 +1,12 @@
import { Injectable, type OnModuleInit } from '@nestjs/common';
import { LoggerService } from '@modules/shared/infrastructure/logger.service';
import * as admin from 'firebase-admin';
import {
apps,
initializeApp,
credential,
messaging,
type ServiceAccount,
} from 'firebase-admin';
import { type LoggerService } from '@modules/shared/infrastructure/logger.service';
export interface SendPushDto {
token: string;
@@ -26,9 +32,9 @@ export class FcmService implements OnModuleInit {
}
try {
const serviceAccount = JSON.parse(serviceAccountJson) as admin.ServiceAccount;
if (!admin.apps.length) {
admin.initializeApp({ credential: admin.credential.cert(serviceAccount) });
const serviceAccount = JSON.parse(serviceAccountJson) as ServiceAccount;
if (!apps.length) {
initializeApp({ credential: credential.cert(serviceAccount) });
}
this.initialized = true;
this.logger.log('Firebase Admin initialized for push notifications', 'FcmService');
@@ -50,7 +56,7 @@ export class FcmService implements OnModuleInit {
}
try {
const messageId = await admin.messaging().send({
const messageId = await messaging().send({
token: dto.token,
notification: {
title: dto.title,

18
apps/api/src/modules/notifications/notifications.module.ts
View File

@@ -1,23 +1,15 @@
import { Module } from '@nestjs/common';
import { CqrsModule } from '@nestjs/cqrs';
// Domain
import { NOTIFICATION_REPOSITORY } from './domain/repositories/notification.repository';
import { SendNotificationHandler } from './application/commands/send-notification/send-notification.handler';
import { AgentVerifiedListener } from './application/listeners/agent-verified.listener';
import { UserRegisteredListener } from './application/listeners/user-registered.listener';
import { NOTIFICATION_PREFERENCE_REPOSITORY } from './domain/repositories/notification-preference.repository';
// Infrastructure
import { PrismaNotificationRepository } from './infrastructure/repositories/prisma-notification.repository';
import { NOTIFICATION_REPOSITORY } from './domain/repositories/notification.repository';
import { PrismaNotificationPreferenceRepository } from './infrastructure/repositories/prisma-notification-preference.repository';
import { PrismaNotificationRepository } from './infrastructure/repositories/prisma-notification.repository';
import { EmailService } from './infrastructure/services/email.service';
import { FcmService } from './infrastructure/services/fcm.service';
import { TemplateService } from './infrastructure/services/template.service';
// Application
import { SendNotificationHandler } from './application/commands/send-notification/send-notification.handler';
import { UserRegisteredListener } from './application/listeners/user-registered.listener';
import { AgentVerifiedListener } from './application/listeners/agent-verified.listener';
// Presentation
import { NotificationsController } from './presentation/controllers/notifications.controller';
const CommandHandlers = [SendNotificationHandler];

11
apps/api/src/modules/notifications/presentation/controllers/notifications.controller.ts
View File

@@ -8,19 +8,18 @@ import {
Inject,
} from '@nestjs/common';
import { AuthGuard } from '@nestjs/passport';
import { ApiTags, ApiOperation, ApiResponse, ApiBearerAuth, ApiQuery } from '@nestjs/swagger';
import { ApiProperty } from '@nestjs/swagger';
import { CurrentUser } from '@modules/auth/presentation/decorators';
import { ApiTags, ApiOperation, ApiResponse, ApiBearerAuth, ApiQuery, ApiProperty } from '@nestjs/swagger';
import { NotificationChannel as PrismaChannel } from '@prisma/client';
import { IsBoolean, IsEnum, IsString } from 'class-validator';
import { type JwtPayload } from '@modules/auth';
import { CurrentUser } from '@modules/auth/presentation/decorators';
import {
NOTIFICATION_REPOSITORY,
type INotificationRepository,
NOTIFICATION_PREFERENCE_REPOSITORY,
type INotificationPreferenceRepository,
} from '../../domain';
import { TemplateService } from '../../infrastructure/services/template.service';
import { IsBoolean, IsEnum, IsString } from 'class-validator';
import { NotificationChannel as PrismaChannel } from '@prisma/client';
import { type TemplateService } from '../../infrastructure/services/template.service';
class UpdatePreferenceDto {
@ApiProperty({ enum: PrismaChannel, description: 'Notification channel' })