refactor(api): replace new Logger() with DI LoggerService and split large files
- Migrate 30 files from `new Logger(ClassName.name)` to injected LoggerService for consistent PII masking and centralized logging config - Split prisma-admin-query.repository.ts (313→121 lines) into admin-stats.queries.ts and admin-user.queries.ts - Split admin.controller.ts (285→154 lines) into admin-moderation.controller.ts - Split prisma-listing.repository.ts (274→111 lines) into listing-read.queries.ts - Update 28 test files with mock LoggerService - All 831 tests passing, zero direct new Logger() calls remaining Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -1,7 +1,8 @@
|
||||
import * as crypto from 'crypto';
|
||||
import { Injectable, Logger } from '@nestjs/common';
|
||||
import { Injectable } from '@nestjs/common';
|
||||
import { type ConfigService } from '@nestjs/config';
|
||||
import { type PaymentProvider } from '@prisma/client';
|
||||
import { type LoggerService } from '@modules/shared';
|
||||
import {
|
||||
type IPaymentGateway,
|
||||
type CreatePaymentUrlParams,
|
||||
@@ -13,7 +14,6 @@ import {
|
||||
|
||||
@Injectable()
|
||||
export class ZalopayService implements IPaymentGateway {
|
||||
private readonly logger = new Logger(ZalopayService.name);
|
||||
readonly provider: PaymentProvider = 'ZALOPAY';
|
||||
|
||||
private readonly appId: string;
|
||||
@@ -21,7 +21,10 @@ export class ZalopayService implements IPaymentGateway {
|
||||
private readonly key2: string;
|
||||
private readonly endpoint: string;
|
||||
|
||||
constructor(private readonly config: ConfigService) {
|
||||
constructor(
|
||||
private readonly config: ConfigService,
|
||||
private readonly logger: LoggerService,
|
||||
) {
|
||||
this.appId = this.config.getOrThrow<string>('ZALOPAY_APP_ID');
|
||||
this.key1 = this.config.getOrThrow<string>('ZALOPAY_KEY1');
|
||||
this.key2 = this.config.getOrThrow<string>('ZALOPAY_KEY2');
|
||||
@@ -80,14 +83,14 @@ export class ZalopayService implements IPaymentGateway {
|
||||
throw new Error(`ZaloPay create payment failed: return_code=${result.return_code}`);
|
||||
}
|
||||
|
||||
this.logger.log(`ZaloPay payment URL created for order ${params.orderId}`);
|
||||
this.logger.log(`ZaloPay payment URL created for order ${params.orderId}`, 'ZalopayService');
|
||||
|
||||
return {
|
||||
paymentUrl: result.order_url,
|
||||
providerTxId: appTransId,
|
||||
};
|
||||
} catch (error) {
|
||||
this.logger.error(`ZaloPay createPaymentUrl error: ${error}`);
|
||||
this.logger.error(`ZaloPay createPaymentUrl error: ${error}`, undefined, 'ZalopayService');
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
@@ -128,6 +131,7 @@ export class ZalopayService implements IPaymentGateway {
|
||||
|
||||
this.logger.log(
|
||||
`ZaloPay callback verified: orderId=${orderId}, valid=${isValid}`,
|
||||
'ZalopayService',
|
||||
);
|
||||
|
||||
return {
|
||||
@@ -179,6 +183,7 @@ export class ZalopayService implements IPaymentGateway {
|
||||
|
||||
this.logger.log(
|
||||
`ZaloPay refund ${success ? 'successful' : 'failed'} for ${params.providerTxId}`,
|
||||
'ZalopayService',
|
||||
);
|
||||
|
||||
return {
|
||||
@@ -186,7 +191,7 @@ export class ZalopayService implements IPaymentGateway {
|
||||
refundTxId: success ? mRefundId : null,
|
||||
};
|
||||
} catch (error) {
|
||||
this.logger.error(`ZaloPay refund error: ${error}`);
|
||||
this.logger.error(`ZaloPay refund error: ${error}`, undefined, 'ZalopayService');
|
||||
return { success: false, refundTxId: null };
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user