From 4c432c7ff90ea0d9cc62a78e42f605d55b46de53 Mon Sep 17 00:00:00 2001
From: Ho Ngoc Hai <hongochai10@icloud.com>
Date: Fri, 10 Apr 2026 18:00:37 +0700
Subject: [PATCH] fix: resolve 21 lint errors from GDPR/logger/caching commits
 and fix web lint

- Fix import ordering in auth DTOs, admin module, and test files
- Merge duplicate @modules/shared imports (no-duplicates with prefer-inline)
- Remove unused imports (ForceDeleteUserCommand, Inject)
- Use parameterless catch for unused error bindings
- Switch web lint from `next lint` to `eslint` (flat config compatibility)

Co-Authored-By: Paperclip <noreply@paperclip.ing>
---
 apps/api/src/modules/admin/admin.module.ts                    | 2 +-
 .../queries/get-district-stats/get-district-stats.handler.ts  | 2 +-
 .../__tests__/process-scheduled-deletions.handler.spec.ts     | 2 --
 .../cancel-user-deletion/cancel-user-deletion.handler.ts      | 3 +--
 .../commands/export-user-data/export-user-data.handler.ts     | 3 +--
 .../commands/force-delete-user/force-delete-user.handler.ts   | 3 +--
 .../request-user-deletion/request-user-deletion.handler.ts    | 4 +---
 .../modules/auth/presentation/dto/force-delete-user.dto.ts    | 2 +-
 .../src/modules/auth/presentation/dto/request-deletion.dto.ts | 2 +-
 .../commands/create-listing/create-listing.handler.ts         | 4 ++--
 .../infrastructure/repositories/prisma-listing.repository.ts  | 3 +--
 .../infrastructure/services/prisma-price-validator.ts         | 2 +-
 apps/web/package.json                                         | 2 +-
 13 files changed, 13 insertions(+), 21 deletions(-)

diff --git a/apps/api/src/modules/admin/admin.module.ts b/apps/api/src/modules/admin/admin.module.ts
index dfb6127..da957ef 100644
--- a/apps/api/src/modules/admin/admin.module.ts
+++ b/apps/api/src/modules/admin/admin.module.ts
@@ -21,8 +21,8 @@ import { GetUserDetailHandler } from './application/queries/get-user-detail/get-
 import { GetUsersHandler } from './application/queries/get-users/get-users.handler';
 import { ADMIN_QUERY_REPOSITORY } from './domain/repositories/admin-query.repository';
 import { PrismaAdminQueryRepository } from './infrastructure/repositories/prisma-admin-query.repository';
-import { AdminController } from './presentation/controllers/admin.controller';
 import { AdminModerationController } from './presentation/controllers/admin-moderation.controller';
+import { AdminController } from './presentation/controllers/admin.controller';
 
 const CommandHandlers = [
   ApproveListingHandler,
diff --git a/apps/api/src/modules/analytics/application/queries/get-district-stats/get-district-stats.handler.ts b/apps/api/src/modules/analytics/application/queries/get-district-stats/get-district-stats.handler.ts
index 38214b1..ddc038e 100644
--- a/apps/api/src/modules/analytics/application/queries/get-district-stats/get-district-stats.handler.ts
+++ b/apps/api/src/modules/analytics/application/queries/get-district-stats/get-district-stats.handler.ts
@@ -1,6 +1,6 @@
 import { Inject } from '@nestjs/common';
 import { QueryHandler, type IQueryHandler } from '@nestjs/cqrs';
-import { CacheService, CachePrefix, CacheTTL, Cacheable } from '@modules/shared';
+import { type CacheService, CachePrefix, CacheTTL, Cacheable } from '@modules/shared';
 import {
   MARKET_INDEX_REPOSITORY,
   type IMarketIndexRepository,
diff --git a/apps/api/src/modules/auth/application/__tests__/process-scheduled-deletions.handler.spec.ts b/apps/api/src/modules/auth/application/__tests__/process-scheduled-deletions.handler.spec.ts
index c594b69..0aa4011 100644
--- a/apps/api/src/modules/auth/application/__tests__/process-scheduled-deletions.handler.spec.ts
+++ b/apps/api/src/modules/auth/application/__tests__/process-scheduled-deletions.handler.spec.ts
@@ -1,6 +1,4 @@
-import { ProcessScheduledDeletionsCommand } from '../commands/process-scheduled-deletions/process-scheduled-deletions.command';
 import { ProcessScheduledDeletionsHandler } from '../commands/process-scheduled-deletions/process-scheduled-deletions.handler';
-import { ForceDeleteUserCommand } from '../commands/force-delete-user/force-delete-user.command';
 
 describe('ProcessScheduledDeletionsHandler', () => {
   let handler: ProcessScheduledDeletionsHandler;
diff --git a/apps/api/src/modules/auth/application/commands/cancel-user-deletion/cancel-user-deletion.handler.ts b/apps/api/src/modules/auth/application/commands/cancel-user-deletion/cancel-user-deletion.handler.ts
index 046149b..7ecab7c 100644
--- a/apps/api/src/modules/auth/application/commands/cancel-user-deletion/cancel-user-deletion.handler.ts
+++ b/apps/api/src/modules/auth/application/commands/cancel-user-deletion/cancel-user-deletion.handler.ts
@@ -1,6 +1,5 @@
 import { CommandHandler, type ICommandHandler } from '@nestjs/cqrs';
-import { type LoggerService, type PrismaService } from '@modules/shared';
-import { NotFoundException, ValidationException } from '@modules/shared';
+import { type LoggerService, type PrismaService, NotFoundException, ValidationException } from '@modules/shared';
 import { CancelUserDeletionCommand } from './cancel-user-deletion.command';
 
 @CommandHandler(CancelUserDeletionCommand)
diff --git a/apps/api/src/modules/auth/application/commands/export-user-data/export-user-data.handler.ts b/apps/api/src/modules/auth/application/commands/export-user-data/export-user-data.handler.ts
index 645f36b..0b0d329 100644
--- a/apps/api/src/modules/auth/application/commands/export-user-data/export-user-data.handler.ts
+++ b/apps/api/src/modules/auth/application/commands/export-user-data/export-user-data.handler.ts
@@ -1,6 +1,5 @@
 import { CommandHandler, type ICommandHandler } from '@nestjs/cqrs';
-import { type LoggerService, type PrismaService } from '@modules/shared';
-import { NotFoundException } from '@modules/shared';
+import { type LoggerService, type PrismaService, NotFoundException } from '@modules/shared';
 import { ExportUserDataCommand } from './export-user-data.command';
 
 export interface UserDataExport {
diff --git a/apps/api/src/modules/auth/application/commands/force-delete-user/force-delete-user.handler.ts b/apps/api/src/modules/auth/application/commands/force-delete-user/force-delete-user.handler.ts
index d490704..5863548 100644
--- a/apps/api/src/modules/auth/application/commands/force-delete-user/force-delete-user.handler.ts
+++ b/apps/api/src/modules/auth/application/commands/force-delete-user/force-delete-user.handler.ts
@@ -1,7 +1,6 @@
 import { CommandHandler, type ICommandHandler } from '@nestjs/cqrs';
 import { Prisma } from '@prisma/client';
-import { type LoggerService, type PrismaService } from '@modules/shared';
-import { NotFoundException } from '@modules/shared';
+import { type LoggerService, type PrismaService, NotFoundException } from '@modules/shared';
 import { ForceDeleteUserCommand } from './force-delete-user.command';
 
 @CommandHandler(ForceDeleteUserCommand)
diff --git a/apps/api/src/modules/auth/application/commands/request-user-deletion/request-user-deletion.handler.ts b/apps/api/src/modules/auth/application/commands/request-user-deletion/request-user-deletion.handler.ts
index f9dc590..df69e9f 100644
--- a/apps/api/src/modules/auth/application/commands/request-user-deletion/request-user-deletion.handler.ts
+++ b/apps/api/src/modules/auth/application/commands/request-user-deletion/request-user-deletion.handler.ts
@@ -1,7 +1,5 @@
-import { Inject } from '@nestjs/common';
 import { CommandHandler, type ICommandHandler } from '@nestjs/cqrs';
-import { type LoggerService, type PrismaService } from '@modules/shared';
-import { NotFoundException, ValidationException } from '@modules/shared';
+import { type LoggerService, type PrismaService, NotFoundException, ValidationException } from '@modules/shared';
 import { RequestUserDeletionCommand } from './request-user-deletion.command';
 
 const DELETION_GRACE_PERIOD_DAYS = 30;
diff --git a/apps/api/src/modules/auth/presentation/dto/force-delete-user.dto.ts b/apps/api/src/modules/auth/presentation/dto/force-delete-user.dto.ts
index 994748e..33abb8e 100644
--- a/apps/api/src/modules/auth/presentation/dto/force-delete-user.dto.ts
+++ b/apps/api/src/modules/auth/presentation/dto/force-delete-user.dto.ts
@@ -1,5 +1,5 @@
-import { IsString, MinLength } from 'class-validator';
 import { ApiProperty } from '@nestjs/swagger';
+import { IsString, MinLength } from 'class-validator';
 
 export class ForceDeleteUserDto {
   @ApiProperty({ description: 'Lý do xóa tài khoản' })
diff --git a/apps/api/src/modules/auth/presentation/dto/request-deletion.dto.ts b/apps/api/src/modules/auth/presentation/dto/request-deletion.dto.ts
index 3f6ca9b..2967c51 100644
--- a/apps/api/src/modules/auth/presentation/dto/request-deletion.dto.ts
+++ b/apps/api/src/modules/auth/presentation/dto/request-deletion.dto.ts
@@ -1,5 +1,5 @@
-import { IsOptional, IsString, MaxLength } from 'class-validator';
 import { ApiPropertyOptional } from '@nestjs/swagger';
+import { IsOptional, IsString, MaxLength } from 'class-validator';
 
 export class RequestDeletionDto {
   @ApiPropertyOptional({ description: 'Lý do xóa tài khoản', maxLength: 500 })
diff --git a/apps/api/src/modules/listings/application/commands/create-listing/create-listing.handler.ts b/apps/api/src/modules/listings/application/commands/create-listing/create-listing.handler.ts
index eb9b280..9cd7448 100644
--- a/apps/api/src/modules/listings/application/commands/create-listing/create-listing.handler.ts
+++ b/apps/api/src/modules/listings/application/commands/create-listing/create-listing.handler.ts
@@ -139,7 +139,7 @@ export class CreateListingHandler implements ICommandHandler<CreateListingComman
         distanceMeters: c.distanceMeters,
         titleSimilarity: c.titleSimilarity,
       }));
-    } catch (err) {
+    } catch {
       this.logger.warn('Duplicate detection failed — listing created without warnings', 'CreateListingHandler');
     }
 
@@ -161,7 +161,7 @@ export class CreateListingHandler implements ICommandHandler<CreateListingComman
           reason: priceResult.reason!,
         };
       }
-    } catch (err) {
+    } catch {
       this.logger.warn('Price validation failed — listing created without price warning', 'CreateListingHandler');
     }
 
diff --git a/apps/api/src/modules/listings/infrastructure/repositories/prisma-listing.repository.ts b/apps/api/src/modules/listings/infrastructure/repositories/prisma-listing.repository.ts
index a7661bf..5ae0f16 100644
--- a/apps/api/src/modules/listings/infrastructure/repositories/prisma-listing.repository.ts
+++ b/apps/api/src/modules/listings/infrastructure/repositories/prisma-listing.repository.ts
@@ -2,8 +2,7 @@ import { Injectable } from '@nestjs/common';
 import { type Listing as PrismaListing, type ListingStatus } from '@prisma/client';
 import { type PrismaService } from '@modules/shared';
 import { ListingEntity, type ListingProps } from '../../domain/entities/listing.entity';
-import { type ListingDetailData } from '../../domain/repositories/listing-read.dto';
-import { type ListingSearchItem, type ListingSellerItem } from '../../domain/repositories/listing-read.dto';
+import { type ListingDetailData, type ListingSearchItem, type ListingSellerItem } from '../../domain/repositories/listing-read.dto';
 import { type IListingRepository, type ListingSearchParams, type PaginatedResult } from '../../domain/repositories/listing.repository';
 import { Price } from '../../domain/value-objects/price.vo';
 import { findByIdWithProperty, searchListings, findBySellerIdQuery } from './listing-read.queries';
diff --git a/apps/api/src/modules/listings/infrastructure/services/prisma-price-validator.ts b/apps/api/src/modules/listings/infrastructure/services/prisma-price-validator.ts
index 87c5190..4987455 100644
--- a/apps/api/src/modules/listings/infrastructure/services/prisma-price-validator.ts
+++ b/apps/api/src/modules/listings/infrastructure/services/prisma-price-validator.ts
@@ -113,7 +113,7 @@ export class PrismaPriceValidator implements IPriceValidator {
         return { min: rows[0]!.min_price, max: rows[0]!.max_price };
       }
       return null;
-    } catch (err) {
+    } catch {
       this.logger.warn('Failed to fetch market range, using defaults', 'PrismaPriceValidator');
       return null;
     }
diff --git a/apps/web/package.json b/apps/web/package.json
index c710246..34b63eb 100644
--- a/apps/web/package.json
+++ b/apps/web/package.json
@@ -6,7 +6,7 @@
     "dev": "next dev --port 3000",
     "build": "next build",
     "start": "next start",
-    "lint": "next lint",
+    "lint": "eslint src/ app/ components/ lib/ hooks/ i18n/ --no-error-on-unmatched-pattern",
     "test": "vitest run",
     "typecheck": "tsc --noEmit"
   },