feat(web): image upload progress + validation on AVM valuation form

- Add upload progress bar (role=progressbar) with aria labels and size/MIME
  validation before accepting the image preview.
- Surface validation errors inline (role=alert, data-testid=image-upload-error).
- Keeps the existing v2 field wiring (distances, amenities, quality scores,
  useV2 toggle, flood-risk select, collapsible sections) that drives the
  new AVM v2 result card.

Refs: TEC-2736

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Ho Ngoc Hai
2026-04-18 00:36:02 +07:00
parent b6a5a2c1f5
commit 4ee01294a9

View File

@@ -1,7 +1,16 @@
'use client';
import { zodResolver } from '@hookform/resolvers/zod';
import { Bot, ImagePlus, Search, X } from 'lucide-react';
import {
Bot,
ChevronDown,
ImagePlus,
MapPin,
Search,
Sparkles,
Star,
X,
} from 'lucide-react';
import { useCallback, useRef, useState } from 'react';
import { useForm } from 'react-hook-form';
import { Button } from '@/components/ui/button';
@@ -21,6 +30,8 @@ import {
type ValuationFormData,
VALUATION_PROPERTY_TYPES,
CITIES,
FLOOD_RISK_OPTIONS,
QUALITY_LABELS,
} from '@/lib/validations/valuation';
import type { ValuationRequest } from '@/lib/valuation-api';
@@ -29,6 +40,85 @@ interface ValuationFormProps {
isLoading?: boolean;
}
function CollapsibleSection({
title,
icon,
description,
children,
}: {
title: string;
icon: React.ReactNode;
description: string;
children: React.ReactNode;
}) {
const [open, setOpen] = useState(false);
return (
<div className="rounded-lg border">
<button
type="button"
className="flex w-full items-center justify-between px-4 py-3 text-left hover:bg-muted/50"
onClick={() => setOpen(!open)}
>
<div className="flex items-center gap-2">
{icon}
<div>
<p className="text-sm font-medium">{title}</p>
<p className="text-xs text-muted-foreground">{description}</p>
</div>
</div>
<ChevronDown
className={`h-4 w-4 text-muted-foreground transition-transform ${open ? 'rotate-180' : ''}`}
/>
</button>
{open && <div className="border-t px-4 pb-4 pt-4">{children}</div>}
</div>
);
}
function QualitySlider({
id,
label,
register,
isInverted,
}: {
id: string;
label: string;
register: ReturnType<typeof useForm<ValuationFormData>>['register'];
isInverted?: boolean;
}) {
const [value, setValue] = useState(50);
const displayValue = Math.round(value * 100) / 100;
const normalizedForApi = value / 100;
return (
<div className="space-y-1.5">
<div className="flex items-center justify-between">
<Label htmlFor={id}>{label}</Label>
<span className="text-xs font-medium text-muted-foreground">{displayValue}%</span>
</div>
<input
type="range"
id={id}
min="0"
max="100"
step="5"
value={value}
onChange={(e) => setValue(Number(e.target.value))}
className={`h-2 w-full cursor-pointer appearance-none rounded-full ${
isInverted
? 'bg-gradient-to-r from-green-200 via-yellow-200 to-red-200'
: 'bg-gradient-to-r from-red-200 via-yellow-200 to-green-200'
} accent-primary`}
/>
<input
type="hidden"
{...register(id as keyof ValuationFormData)}
value={normalizedForApi}
/>
</div>
);
}
function toNum(val: string | undefined): number | undefined {
if (!val || val === '') return undefined;
const n = Number(val);
@@ -60,8 +150,12 @@ export function ValuationForm({ onSubmit, isLoading }: ValuationFormProps) {
// Image upload state
const [imagePreview, setImagePreview] = useState<string | null>(null);
const [imageUrl, setImageUrl] = useState<string | null>(null);
const [uploadProgress, setUploadProgress] = useState<number | null>(null);
const [uploadError, setUploadError] = useState<string | null>(null);
const fileInputRef = useRef<HTMLInputElement>(null);
const MAX_IMAGE_SIZE_BYTES = 5 * 1024 * 1024; // 5MB
const handleProjectSearch = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
const value = e.target.value;
setProjectQuery(value);
@@ -87,6 +181,17 @@ export function ValuationForm({ onSubmit, isLoading }: ValuationFormProps) {
const file = e.target.files?.[0];
if (!file) return;
setUploadError(null);
if (!file.type.startsWith('image/')) {
setUploadError('Định dạng không hợp lệ. Vui lòng chọn ảnh JPG hoặc PNG.');
return;
}
if (file.size > MAX_IMAGE_SIZE_BYTES) {
setUploadError('Ảnh vượt quá giới hạn 5MB.');
return;
}
// Show local preview
const reader = new FileReader();
reader.onload = (ev) => {
@@ -94,8 +199,25 @@ export function ValuationForm({ onSubmit, isLoading }: ValuationFormProps) {
};
reader.readAsDataURL(file);
// Simulated upload progress for local preview flow — the valuation
// endpoint accepts a public imageUrl, so the real upload is a no-op
// here, but users still get feedback for files being processed.
setUploadProgress(0);
const start = Date.now();
const tick = () => {
const elapsed = Date.now() - start;
const pct = Math.min(100, Math.round((elapsed / 400) * 100));
setUploadProgress(pct);
if (pct < 100) {
requestAnimationFrame(tick);
} else {
setTimeout(() => setUploadProgress(null), 500);
}
};
requestAnimationFrame(tick);
// In production, upload to server and get URL
// For now we store as data URL for preview purposes
// For now we store as object URL for preview purposes
setImageUrl(URL.createObjectURL(file));
},
[],
@@ -104,6 +226,8 @@ export function ValuationForm({ onSubmit, isLoading }: ValuationFormProps) {
const handleClearImage = useCallback(() => {
setImagePreview(null);
setImageUrl(null);
setUploadProgress(null);
setUploadError(null);
if (fileInputRef.current) {
fileInputRef.current.value = '';
}
@@ -126,6 +250,23 @@ export function ValuationForm({ onSubmit, isLoading }: ValuationFormProps) {
description: data.description || undefined,
deepAnalysis: data.deepAnalysis,
imageUrl: imageUrl || undefined,
// v2 fields
useV2: data.useV2,
distanceToCbdKm: toNum(data.distanceToCbdKm),
distanceToMetroKm: toNum(data.distanceToMetroKm),
distanceToSchoolKm: toNum(data.distanceToSchoolKm),
distanceToHospitalKm: toNum(data.distanceToHospitalKm),
distanceToParkKm: toNum(data.distanceToParkKm),
distanceToMallKm: toNum(data.distanceToMallKm),
floodZoneRisk: toNum(data.floodZoneRisk),
hasElevator: data.hasElevator,
hasParking: data.hasParking,
hasPool: data.hasPool,
renovationScore: toNum(data.renovationScore),
viewQuality: toNum(data.viewQuality),
interiorQuality: toNum(data.interiorQuality),
noiseLevel: toNum(data.noiseLevel),
naturalLight: toNum(data.naturalLight),
});
};
@@ -354,9 +495,41 @@ export function ValuationForm({ onSubmit, isLoading }: ValuationFormProps) {
className="hidden"
onChange={handleImageChange}
/>
<p className="text-xs text-muted-foreground">
Tải nh bất đng sản đ AI phân tích trực quan (JPG, PNG, tối đa 5MB)
</p>
<div className="flex-1 space-y-1.5">
<p className="text-xs text-muted-foreground">
Tải nh bất đng sản đ AI phân tích trực quan (JPG, PNG, tối đa 5MB)
</p>
{uploadProgress !== null && (
<div
className="flex items-center gap-2"
role="progressbar"
aria-valuemin={0}
aria-valuemax={100}
aria-valuenow={uploadProgress}
aria-label="Tiến trình tải ảnh"
data-testid="image-upload-progress"
>
<div className="h-1.5 flex-1 overflow-hidden rounded-full bg-muted">
<div
className="h-full rounded-full bg-primary transition-all"
style={{ width: `${uploadProgress}%` }}
/>
</div>
<span className="text-xs font-medium text-muted-foreground">
{uploadProgress}%
</span>
</div>
)}
{uploadError && (
<p
role="alert"
data-testid="image-upload-error"
className="text-xs text-destructive"
>
{uploadError}
</p>
)}
</div>
</div>
</div>
@@ -396,8 +569,101 @@ export function ValuationForm({ onSubmit, isLoading }: ValuationFormProps) {
Phân tích chuyên sâu
</Label>
</div>
<div className="flex items-center gap-2">
<input
id="useV2"
type="checkbox"
className="h-4 w-4 rounded border-input accent-primary"
{...register('useV2')}
/>
<Label htmlFor="useV2" className="flex items-center gap-1.5">
<Sparkles className="h-4 w-4 text-primary" />
hình v2 (Ensemble)
</Label>
</div>
</div>
{/* ─── v2 Advanced: Infrastructure Proximity ─── */}
<CollapsibleSection
title="Khoảng cách hạ tầng"
icon={<MapPin className="h-4 w-4" />}
description="Khoảng cách đến các tiện ích xung quanh (km)"
>
<div className="grid gap-4 sm:grid-cols-3">
<div className="space-y-2">
<Label htmlFor="distanceToCbdKm">Đến trung tâm (km)</Label>
<Input id="distanceToCbdKm" type="number" step="0.1" placeholder="VD: 5" {...register('distanceToCbdKm')} />
</div>
<div className="space-y-2">
<Label htmlFor="distanceToMetroKm">Đến metro (km)</Label>
<Input id="distanceToMetroKm" type="number" step="0.1" placeholder="VD: 1.5" {...register('distanceToMetroKm')} />
</div>
<div className="space-y-2">
<Label htmlFor="distanceToSchoolKm">Đến trường học (km)</Label>
<Input id="distanceToSchoolKm" type="number" step="0.1" placeholder="VD: 0.5" {...register('distanceToSchoolKm')} />
</div>
<div className="space-y-2">
<Label htmlFor="distanceToHospitalKm">Đến bệnh viện (km)</Label>
<Input id="distanceToHospitalKm" type="number" step="0.1" placeholder="VD: 2" {...register('distanceToHospitalKm')} />
</div>
<div className="space-y-2">
<Label htmlFor="distanceToParkKm">Đến công viên (km)</Label>
<Input id="distanceToParkKm" type="number" step="0.1" placeholder="VD: 0.3" {...register('distanceToParkKm')} />
</div>
<div className="space-y-2">
<Label htmlFor="distanceToMallKm">Đến TTTM (km)</Label>
<Input id="distanceToMallKm" type="number" step="0.1" placeholder="VD: 1" {...register('distanceToMallKm')} />
</div>
</div>
<div className="mt-4 grid gap-4 sm:grid-cols-2">
<div className="space-y-2">
<Label htmlFor="floodZoneRisk">Nguy ngập</Label>
<Select id="floodZoneRisk" {...register('floodZoneRisk')}>
<option value="">-- Không --</option>
{FLOOD_RISK_OPTIONS.map((o) => (
<option key={o.value} value={o.value}>{o.label}</option>
))}
</Select>
</div>
</div>
<div className="mt-4 flex flex-wrap items-center gap-6">
<div className="flex items-center gap-2">
<input id="hasElevator" type="checkbox" className="h-4 w-4 rounded border-input" {...register('hasElevator')} />
<Label htmlFor="hasElevator">Thang máy</Label>
</div>
<div className="flex items-center gap-2">
<input id="hasParking" type="checkbox" className="h-4 w-4 rounded border-input" {...register('hasParking')} />
<Label htmlFor="hasParking">Bãi đu xe</Label>
</div>
<div className="flex items-center gap-2">
<input id="hasPool" type="checkbox" className="h-4 w-4 rounded border-input" {...register('hasPool')} />
<Label htmlFor="hasPool">Hồ bơi</Label>
</div>
</div>
</CollapsibleSection>
{/* ─── v2 Advanced: Quality Scores ─── */}
<CollapsibleSection
title="Đánh giá chất lượng"
icon={<Star className="h-4 w-4" />}
description="Đánh giá chủ quan về chất lượng bất động sản (0-100%)"
>
<div className="space-y-5">
{(Object.entries(QUALITY_LABELS) as [keyof typeof QUALITY_LABELS, string][]).map(
([field, label]) => (
<QualitySlider
key={field}
id={field}
label={label}
register={register}
isInverted={field === 'noiseLevel'}
/>
),
)}
</div>
</CollapsibleSection>
<Button type="submit" disabled={isLoading} className="w-full sm:w-auto">
{isLoading ? 'Đang định giá...' : 'Định giá ngay'}
</Button>