fix(maps): marker hover no longer teleports to (0, 0)
Some checks failed
CI / Lint → Typecheck → Test → Build (22) (push) Failing after 6s
CodeQL Analysis / CodeQL (javascript-typescript) (push) Failing after 40s
Deploy / Build API Image (push) Failing after 17s
Deploy / Build Web Image (push) Failing after 10s
Deploy / Build AI Services Image (push) Failing after 11s
CI / E2E Tests (push) Has been skipped
E2E Tests / Playwright E2E (push) Failing after 10s
Security Scanning / Dependency Audit (pnpm) (push) Failing after 2s
Security Scanning / Trivy Scan — API Image (push) Failing after 47s
Security Scanning / Trivy Scan — Web Image (push) Failing after 27s
Security Scanning / Trivy Scan — AI Services Image (push) Failing after 41s
Security Scanning / Trivy Filesystem Scan (push) Failing after 34s
Deploy / Deploy to Staging (push) Has been skipped
Deploy / Smoke Test Staging (push) Has been skipped
Deploy / Deploy to Production (push) Has been skipped
Deploy / Smoke Test Production (push) Has been skipped
Security Scanning / Security Gate (push) Failing after 2s
Deploy / Rollback Staging (push) Has been skipped
Deploy / Rollback Production (push) Has been skipped

Mapbox GL JS writes `transform: translate(Xpx, Ypx)` on the DOM
element passed to `new Marker({ element })`. Any code that does
`el.style.transform = 'scale(...)'` on that same element CLOBBERS
the translate and the marker snaps to the map origin (top-left).

Five map components were doing exactly this in their hover listeners:
- components/neighborhood/neighborhood-poi-map.tsx
- components/du-an/project-map.tsx
- components/khu-cong-nghiep/park-map.tsx
- components/charts/district-heatmap.tsx
- components/valuation/comparables-map.tsx

Fix: wrap the visible marker chrome in an inner <div> and apply the
hover scale to that wrapper. The outer element becomes a thin sizing
shell that Mapbox can keep positioning untouched. Also set
`pointer-events: none` on the inner where the wrapper already has
an interactive role so clicks still bubble to the setPopup-bound
outer element.

Verified on /listings/[id]: POI marker no longer moves on hover,
popup still opens on click with the Phase-C close button.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ho Ngoc Hai
2026-04-19 17:47:05 +07:00
parent 6b783c357d
commit 66eae72f62
5 changed files with 61 additions and 32 deletions

View File

@@ -160,24 +160,32 @@ export function DistrictHeatmap({ data, city, className, onDistrictClick }: Dist
const ratio = point.avgPriceM2 / maxPrice; const ratio = point.avgPriceM2 / maxPrice;
const size = 36 + ratio * 28; // 36px to 64px const size = 36 + ratio * 28; // 36px to 64px
// Mapbox writes `transform: translate(...)` on the marker element;
// hover-scaling the outer element clobbers it. Scale an inner div
// instead.
const el = document.createElement('button'); const el = document.createElement('button');
el.style.cssText = ` el.style.cssText = `width: ${size}px; height: ${size}px; padding: 0; border: none; background: transparent; cursor: pointer;`;
width: ${size}px; height: ${size}px; const inner = document.createElement('div');
inner.style.cssText = `
width: 100%; height: 100%;
border-radius: 50%; border: 2px solid white; border-radius: 50%; border: 2px solid white;
background: ${priceColor(ratio)}; background: ${priceColor(ratio)};
opacity: 0.8; cursor: pointer; opacity: 0.8;
display: flex; align-items: center; justify-content: center; display: flex; align-items: center; justify-content: center;
font-size: 10px; font-weight: 700; color: white; font-size: 10px; font-weight: 700; color: white;
text-shadow: 0 1px 2px rgba(0,0,0,0.5); text-shadow: 0 1px 2px rgba(0,0,0,0.5);
box-shadow: 0 2px 6px rgba(0,0,0,0.3); box-shadow: 0 2px 6px rgba(0,0,0,0.3);
transition: transform 0.15s, opacity 0.15s; transition: transform 0.15s, opacity 0.15s;
transform: scale(1);
padding: 2px; padding: 2px;
line-height: 1.1; line-height: 1.1;
text-align: center; text-align: center;
pointer-events: none;
`; `;
el.textContent = point.district.replace(/^Quan\s*/i, 'Q.').replace(/^Huyen\s*/i, 'H.'); inner.textContent = point.district.replace(/^Quan\s*/i, 'Q.').replace(/^Huyen\s*/i, 'H.');
el.addEventListener('mouseenter', () => { el.style.opacity = '1'; el.style.transform = 'scale(1.15)'; }); el.appendChild(inner);
el.addEventListener('mouseleave', () => { el.style.opacity = '0.8'; el.style.transform = 'scale(1)'; }); el.addEventListener('mouseenter', () => { inner.style.opacity = '1'; inner.style.transform = 'scale(1.15)'; });
el.addEventListener('mouseleave', () => { inner.style.opacity = '0.8'; inner.style.transform = 'scale(1)'; });
el.addEventListener('click', (e) => { el.addEventListener('click', (e) => {
e.stopPropagation(); e.stopPropagation();
onDistrictClick?.(point.district); onDistrictClick?.(point.district);

View File

@@ -80,9 +80,12 @@ export function ProjectMap({ projects, className }: ProjectMapProps) {
const bounds = new mapboxgl.LngLatBounds(); const bounds = new mapboxgl.LngLatBounds();
geoProjects.forEach((project) => { geoProjects.forEach((project) => {
// Mapbox owns `transform: translate(...)` on the marker element.
// Apply hover scale to an inner wrapper so we don't clobber it.
const el = document.createElement('div'); const el = document.createElement('div');
el.className = 'project-map-marker'; el.className = 'project-map-marker';
el.style.cssText = ` const inner = document.createElement('div');
inner.style.cssText = `
background: hsl(var(--card)); background: hsl(var(--card));
color: hsl(var(--card-foreground)); color: hsl(var(--card-foreground));
border-radius: 8px; border-radius: 8px;
@@ -94,16 +97,18 @@ export function ProjectMap({ projects, className }: ProjectMapProps) {
cursor: pointer; cursor: pointer;
border-left: 3px solid hsl(var(--primary)); border-left: 3px solid hsl(var(--primary));
transition: transform 0.15s; transition: transform 0.15s;
transform: scale(1);
max-width: 160px; max-width: 160px;
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
`; `;
el.textContent = project.name; inner.textContent = project.name;
el.appendChild(inner);
el.addEventListener('mouseenter', () => { el.addEventListener('mouseenter', () => {
el.style.transform = 'scale(1.05)'; inner.style.transform = 'scale(1.05)';
}); });
el.addEventListener('mouseleave', () => { el.addEventListener('mouseleave', () => {
el.style.transform = 'scale(1)'; inner.style.transform = 'scale(1)';
}); });
const statusLabel = PROJECT_STATUS_LABELS[project.status]; const statusLabel = PROJECT_STATUS_LABELS[project.status];

View File

@@ -76,9 +76,12 @@ export function ParkMap({ parks, className }: ParkMapProps) {
const bounds = new mapboxgl.LngLatBounds(); const bounds = new mapboxgl.LngLatBounds();
geoParks.forEach((park) => { geoParks.forEach((park) => {
// Mapbox owns `transform: translate(...)` on the marker element.
// Apply hover scale to an inner wrapper so we don't clobber it.
const el = document.createElement('div'); const el = document.createElement('div');
el.className = 'park-map-marker'; el.className = 'park-map-marker';
el.style.cssText = ` const inner = document.createElement('div');
inner.style.cssText = `
background: hsl(var(--card)); background: hsl(var(--card));
color: hsl(var(--card-foreground)); color: hsl(var(--card-foreground));
border-radius: 8px; border-radius: 8px;
@@ -90,16 +93,18 @@ export function ParkMap({ parks, className }: ParkMapProps) {
cursor: pointer; cursor: pointer;
border-left: 3px solid hsl(var(--primary)); border-left: 3px solid hsl(var(--primary));
transition: transform 0.15s; transition: transform 0.15s;
transform: scale(1);
max-width: 160px; max-width: 160px;
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
`; `;
el.textContent = park.name; inner.textContent = park.name;
el.appendChild(inner);
el.addEventListener('mouseenter', () => { el.addEventListener('mouseenter', () => {
el.style.transform = 'scale(1.05)'; inner.style.transform = 'scale(1.05)';
}); });
el.addEventListener('mouseleave', () => { el.addEventListener('mouseleave', () => {
el.style.transform = 'scale(1)'; inner.style.transform = 'scale(1)';
}); });
const statusLabel = PARK_STATUS_LABELS[park.status]; const statusLabel = PARK_STATUS_LABELS[park.status];

View File

@@ -122,11 +122,20 @@ export function NeighborhoodPOIMap({
visiblePois.forEach((poi) => { visiblePois.forEach((poi) => {
const config = POI_CATEGORY_CONFIG[poi.category]; const config = POI_CATEGORY_CONFIG[poi.category];
// Mapbox Marker writes its own `transform: translate(Xpx, Ypx)…` on
// the element it's given. If we mutate `el.style.transform` (e.g. to
// scale on hover), it clobbers the translate and the marker snaps to
// (0, 0). Wrap the visible circle in an INNER div and scale that
// instead, leaving Mapbox's outer transform untouched.
const el = document.createElement('div'); const el = document.createElement('div');
el.className = 'poi-marker'; el.className = 'poi-marker';
el.style.cssText = ` el.style.cssText = `width: 32px; height: 32px; cursor: pointer;`;
width: 32px; el.title = `${poi.name} (${config.label})`;
height: 32px;
const inner = document.createElement('div');
inner.style.cssText = `
width: 100%;
height: 100%;
border-radius: 50%; border-radius: 50%;
background: ${config.color}; background: ${config.color};
border: 2px solid white; border: 2px solid white;
@@ -134,22 +143,18 @@ export function NeighborhoodPOIMap({
display: flex; display: flex;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
cursor: pointer;
transition: transform 0.15s; transition: transform 0.15s;
transform: scale(1);
pointer-events: none;
`; `;
el.innerHTML = POI_MARKER_SVG[poi.category]; inner.innerHTML = POI_MARKER_SVG[poi.category];
el.title = `${poi.name} (${config.label})`; el.appendChild(inner);
// Inner SVG would otherwise swallow the click before Mapbox's marker
// handler sees it — mark it as passthrough so pointer events hit the
// wrapping .poi-marker div that Mapbox bound setPopup to.
const innerSvg = el.querySelector('svg');
if (innerSvg) innerSvg.style.pointerEvents = 'none';
el.addEventListener('mouseenter', () => { el.addEventListener('mouseenter', () => {
el.style.transform = 'scale(1.3)'; inner.style.transform = 'scale(1.3)';
}); });
el.addEventListener('mouseleave', () => { el.addEventListener('mouseleave', () => {
el.style.transform = 'scale(1)'; inner.style.transform = 'scale(1)';
}); });
const popup = new mapboxgl.Popup({ offset: 20, closeButton: true, closeOnClick: true }) const popup = new mapboxgl.Popup({ offset: 20, closeButton: true, closeOnClick: true })

View File

@@ -127,10 +127,14 @@ export function ComparablesMap({
geoComparables.forEach((comp) => { geoComparables.forEach((comp) => {
const color = similarityColor(comp.similarity); const color = similarityColor(comp.similarity);
// Mapbox owns `transform: translate(...)` on the outer element;
// apply hover scale to an inner wrapper to avoid clobbering it.
const el = document.createElement('div'); const el = document.createElement('div');
el.setAttribute('data-testid', 'comparables-map-marker'); el.setAttribute('data-testid', 'comparables-map-marker');
el.style.cssText = ` const inner = document.createElement('div');
background: white; inner.style.cssText = `
background: hsl(var(--card));
color: hsl(var(--card-foreground));
border-radius: 8px; border-radius: 8px;
padding: 4px 8px; padding: 4px 8px;
font-size: 11px; font-size: 11px;
@@ -140,16 +144,18 @@ export function ComparablesMap({
cursor: pointer; cursor: pointer;
border-left: 3px solid ${color}; border-left: 3px solid ${color};
transition: transform 0.15s; transition: transform 0.15s;
transform: scale(1);
max-width: 180px; max-width: 180px;
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
`; `;
el.textContent = formatPrice(comp.priceVND); inner.textContent = formatPrice(comp.priceVND);
el.appendChild(inner);
el.addEventListener('mouseenter', () => { el.addEventListener('mouseenter', () => {
el.style.transform = 'scale(1.08)'; inner.style.transform = 'scale(1.08)';
}); });
el.addEventListener('mouseleave', () => { el.addEventListener('mouseleave', () => {
el.style.transform = 'scale(1)'; inner.style.transform = 'scale(1)';
}); });
const popup = new mapboxgl.Popup({ const popup = new mapboxgl.Popup({