feat(listings+projects): wire listing PATCH + project rich content parity
Some checks failed
CI / Lint → Typecheck → Test → Build (22) (push) Failing after 10s
Security Scanning / Dependency Audit (pnpm) (push) Failing after 2s
Security Scanning / Trivy Scan — API Image (push) Failing after 28s
Deploy / Deploy to Staging (push) Has been skipped
Deploy / Smoke Test Staging (push) Has been skipped
Deploy / Smoke Test Production (push) Has been skipped
Deploy / Rollback Staging (push) Has been skipped
Deploy / Rollback Production (push) Has been skipped
CI / E2E Tests (push) Has been skipped
CodeQL Analysis / CodeQL (javascript-typescript) (push) Failing after 37s
Deploy / Build API Image (push) Failing after 12s
Deploy / Build Web Image (push) Failing after 10s
Deploy / Build AI Services Image (push) Failing after 9s
E2E Tests / Playwright E2E (push) Failing after 9s
Security Scanning / Trivy Scan — Web Image (push) Failing after 38s
Security Scanning / Trivy Scan — AI Services Image (push) Failing after 38s
Security Scanning / Trivy Filesystem Scan (push) Failing after 28s
Deploy / Deploy to Production (push) Has been skipped
Security Scanning / Security Gate (push) Failing after 1s

Two CRUD/parity gaps closed:

Listings edit — PATCH was dead-ended at the frontend
----------------------------------------------------
Backend PATCH /listings/:id existed and accepted Phase B fields but
the dashboard edit page was read-only with a disclaimer stub. Now:
- listings-api.ts exports UpdateListingPayload (Partial<CreatePayload>)
  and listingsApi.update(id, data).
- /listings/[id]/edit/page.tsx wires handleSubmit → maps the form to
  UpdateListingPayload (coerces numerics, splits CSV amenities/view/
  suitableFor, normalises petFriendly 3-way select), calls update,
  shows green success banner or red error banner. Removed the
  disclaimer text.
- Form footer now has Huỷ + Lưu thay đổi buttons.

Projects rich content — parity with Phase B listings
---------------------------------------------------
Same "Phù hợp với ai / Vì sao nên chọn dự án này" pattern now on
project detail.

Schema
- ProjectDevelopment: suitableFor String[] @default([]) +
  whyThisLocation String? @db.Text. Migration 20260419100000 applied
  via db:push.

Backend
- CreateProjectDto / UpdateProjectDto pick up optional suitableFor +
  whyThisLocation (MaxLength 2000).
- CreateProjectCommand / UpdateProjectCommand append the two trailing
  args; handlers forward them.
- ProjectDevelopment entity carries the props + updateDetails
  branches.
- ProjectListItem (inherited by ProjectDetailData) exposes both.
- Prisma repo writes them on raw INSERT/UPDATE and reads them in
  toDomain + toListItem. Controller passes dto → commands.

Frontend
- du-an-api.ts: ProjectDetail / CreateProjectPayload /
  UpdateProjectPayload gain suitableFor + whyThisLocation. duAnApi
  exports create / update / delete (already landed earlier, now in
  sync with the new fields).
- du-an-server.ts normalizer pulls the two fields safely (filter
  strings, default empty array / null).
- Dashboard /projects/new + /projects/[id]/edit: new "Phù hợp & lý
  do khu vực" form section (CSV split + 2000-char textarea). Submit
  handlers forward to create/update payloads.
- Public /du-an/[slug] detail (du-an-detail-client.tsx): two new
  cards just below the quick-stats grid —
  * ProjectPersonaFitCard: chips for each suitableFor label with a
    "Chủ đầu tư chọn" badge (bg-primary/10), plus a disabled
    <Button><Sparkles /> AI nhận định dự án (sắp ra mắt)</Button>
    teaser with a TODO pointing to a future project-AI advisor
    endpoint.
  * ProjectWhyLocationCard: renders whyThisLocation in
    whitespace-pre-wrap; skipped when the field is empty.

Verification
- API typecheck clean; 1975/1975 tests pass.
- Web typecheck clean in touched files; 624/624 tests pass.
- Lucide-only icons; Vietnamese labels; no new npm packages;
  runtime imports preserved for NestJS-DI classes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ho Ngoc Hai
2026-04-19 16:33:54 +07:00
parent 631e1200a1
commit 6b783c357d
20 changed files with 379 additions and 31 deletions

View File

@@ -90,6 +90,12 @@ const projectSchema = z.object({
completionDate: z.string().optional(),
tags: z.string().optional(),
suitableFor: z.string().optional(),
whyThisLocation: z
.string()
.max(2000, 'Tối đa 2000 ký tự')
.optional(),
});
type ProjectFormData = z.infer<typeof projectSchema>;
@@ -164,6 +170,14 @@ export default function CreateProjectPage() {
.filter(Boolean);
if (tags.length > 0) payload.tags = tags;
}
if (data.suitableFor) {
const suitableFor = data.suitableFor
.split(',')
.map((s) => s.trim())
.filter(Boolean);
if (suitableFor.length > 0) payload.suitableFor = suitableFor;
}
if (data.whyThisLocation) payload.whyThisLocation = data.whyThisLocation;
await duAnApi.create(payload);
setSuccess(true);
@@ -408,6 +422,34 @@ export default function CreateProjectPage() {
</div>
</FormSection>
{/* Phù hợp & lý do khu vực */}
<FormSection title="Phù hợp & lý do khu vực">
<div className="space-y-1.5 sm:col-span-2">
<Label htmlFor="suitableFor">Phù hợp với ai (phân cách bởi dấu phẩy)</Label>
<Input
id="suitableFor"
{...register('suitableFor')}
placeholder="Gia đình trẻ, Chuyên gia nước ngoài, Nhà đầu tư"
/>
<p className="text-xs text-muted-foreground">
Mỗi nhóm đi tượng một chip hiển thị trên trang dự án.
</p>
</div>
<div className="space-y-1.5 sm:col-span-2">
<Label htmlFor="whyThisLocation"> sao nên chọn khu vực này</Label>
<Textarea
id="whyThisLocation"
rows={4}
maxLength={2000}
{...register('whyThisLocation')}
placeholder="Mô tả ngắn vì sao khu vực này phù hợp..."
/>
{errors.whyThisLocation && (
<p className="text-xs text-destructive">{errors.whyThisLocation.message}</p>
)}
</div>
</FormSection>
{/* Thời gian */}
<FormSection title="Thời gian">
<div className="space-y-1.5">