feat(listings+projects): wire listing PATCH + project rich content parity
Some checks failed
CI / Lint → Typecheck → Test → Build (22) (push) Failing after 10s
Security Scanning / Dependency Audit (pnpm) (push) Failing after 2s
Security Scanning / Trivy Scan — API Image (push) Failing after 28s
Deploy / Deploy to Staging (push) Has been skipped
Deploy / Smoke Test Staging (push) Has been skipped
Deploy / Smoke Test Production (push) Has been skipped
Deploy / Rollback Staging (push) Has been skipped
Deploy / Rollback Production (push) Has been skipped
CI / E2E Tests (push) Has been skipped
CodeQL Analysis / CodeQL (javascript-typescript) (push) Failing after 37s
Deploy / Build API Image (push) Failing after 12s
Deploy / Build Web Image (push) Failing after 10s
Deploy / Build AI Services Image (push) Failing after 9s
E2E Tests / Playwright E2E (push) Failing after 9s
Security Scanning / Trivy Scan — Web Image (push) Failing after 38s
Security Scanning / Trivy Scan — AI Services Image (push) Failing after 38s
Security Scanning / Trivy Filesystem Scan (push) Failing after 28s
Deploy / Deploy to Production (push) Has been skipped
Security Scanning / Security Gate (push) Failing after 1s
Some checks failed
CI / Lint → Typecheck → Test → Build (22) (push) Failing after 10s
Security Scanning / Dependency Audit (pnpm) (push) Failing after 2s
Security Scanning / Trivy Scan — API Image (push) Failing after 28s
Deploy / Deploy to Staging (push) Has been skipped
Deploy / Smoke Test Staging (push) Has been skipped
Deploy / Smoke Test Production (push) Has been skipped
Deploy / Rollback Staging (push) Has been skipped
Deploy / Rollback Production (push) Has been skipped
CI / E2E Tests (push) Has been skipped
CodeQL Analysis / CodeQL (javascript-typescript) (push) Failing after 37s
Deploy / Build API Image (push) Failing after 12s
Deploy / Build Web Image (push) Failing after 10s
Deploy / Build AI Services Image (push) Failing after 9s
E2E Tests / Playwright E2E (push) Failing after 9s
Security Scanning / Trivy Scan — Web Image (push) Failing after 38s
Security Scanning / Trivy Scan — AI Services Image (push) Failing after 38s
Security Scanning / Trivy Filesystem Scan (push) Failing after 28s
Deploy / Deploy to Production (push) Has been skipped
Security Scanning / Security Gate (push) Failing after 1s
Two CRUD/parity gaps closed:
Listings edit — PATCH was dead-ended at the frontend
----------------------------------------------------
Backend PATCH /listings/:id existed and accepted Phase B fields but
the dashboard edit page was read-only with a disclaimer stub. Now:
- listings-api.ts exports UpdateListingPayload (Partial<CreatePayload>)
and listingsApi.update(id, data).
- /listings/[id]/edit/page.tsx wires handleSubmit → maps the form to
UpdateListingPayload (coerces numerics, splits CSV amenities/view/
suitableFor, normalises petFriendly 3-way select), calls update,
shows green success banner or red error banner. Removed the
disclaimer text.
- Form footer now has Huỷ + Lưu thay đổi buttons.
Projects rich content — parity with Phase B listings
---------------------------------------------------
Same "Phù hợp với ai / Vì sao nên chọn dự án này" pattern now on
project detail.
Schema
- ProjectDevelopment: suitableFor String[] @default([]) +
whyThisLocation String? @db.Text. Migration 20260419100000 applied
via db:push.
Backend
- CreateProjectDto / UpdateProjectDto pick up optional suitableFor +
whyThisLocation (MaxLength 2000).
- CreateProjectCommand / UpdateProjectCommand append the two trailing
args; handlers forward them.
- ProjectDevelopment entity carries the props + updateDetails
branches.
- ProjectListItem (inherited by ProjectDetailData) exposes both.
- Prisma repo writes them on raw INSERT/UPDATE and reads them in
toDomain + toListItem. Controller passes dto → commands.
Frontend
- du-an-api.ts: ProjectDetail / CreateProjectPayload /
UpdateProjectPayload gain suitableFor + whyThisLocation. duAnApi
exports create / update / delete (already landed earlier, now in
sync with the new fields).
- du-an-server.ts normalizer pulls the two fields safely (filter
strings, default empty array / null).
- Dashboard /projects/new + /projects/[id]/edit: new "Phù hợp & lý
do khu vực" form section (CSV split + 2000-char textarea). Submit
handlers forward to create/update payloads.
- Public /du-an/[slug] detail (du-an-detail-client.tsx): two new
cards just below the quick-stats grid —
* ProjectPersonaFitCard: chips for each suitableFor label with a
"Chủ đầu tư chọn" badge (bg-primary/10), plus a disabled
<Button><Sparkles /> AI nhận định dự án (sắp ra mắt)</Button>
teaser with a TODO pointing to a future project-AI advisor
endpoint.
* ProjectWhyLocationCard: renders whyThisLocation in
whitespace-pre-wrap; skipped when the field is empty.
Verification
- API typecheck clean; 1975/1975 tests pass.
- Web typecheck clean in touched files; 624/624 tests pass.
- Lucide-only icons; Vietnamese labels; no new npm packages;
runtime imports preserved for NestJS-DI classes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -120,6 +120,8 @@ export interface ProjectDetail extends ProjectSummary {
|
||||
pois: ProjectPOI[];
|
||||
documents: ProjectDocument[];
|
||||
linkedListingCount: number;
|
||||
suitableFor?: string[];
|
||||
whyThisLocation?: string | null;
|
||||
}
|
||||
|
||||
export interface PaginatedResult<T> {
|
||||
@@ -154,6 +156,8 @@ export interface CreateProjectPayload {
|
||||
floorCount?: number;
|
||||
unitTypes?: Record<string, unknown>;
|
||||
tags?: string[];
|
||||
suitableFor?: string[];
|
||||
whyThisLocation?: string;
|
||||
startDate?: string;
|
||||
completionDate?: string;
|
||||
}
|
||||
@@ -178,6 +182,8 @@ export interface UpdateProjectPayload {
|
||||
media?: Record<string, unknown>[] | null;
|
||||
documents?: Record<string, unknown>[] | null;
|
||||
tags?: string[];
|
||||
suitableFor?: string[];
|
||||
whyThisLocation?: string | null;
|
||||
isVerified?: boolean;
|
||||
startDate?: string | null;
|
||||
completionDate?: string | null;
|
||||
|
||||
@@ -130,6 +130,11 @@ function normalizeProjectDetail(raw: unknown): ProjectDetail | null {
|
||||
documents: asArray(r['documents']),
|
||||
linkedListingCount:
|
||||
typeof r['linkedListingCount'] === 'number' ? (r['linkedListingCount'] as number) : 0,
|
||||
suitableFor: Array.isArray(r['suitableFor'])
|
||||
? (r['suitableFor'] as unknown[]).filter((v): v is string => typeof v === 'string')
|
||||
: [],
|
||||
whyThisLocation:
|
||||
typeof r['whyThisLocation'] === 'string' ? (r['whyThisLocation'] as string) : null,
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
@@ -185,6 +185,8 @@ export interface NeighborhoodScoreResult {
|
||||
|
||||
const API_BASE_URL = process.env['NEXT_PUBLIC_API_URL'] || 'http://localhost:3001/api/v1';
|
||||
|
||||
export interface UpdateListingPayload extends Partial<CreateListingPayload> {}
|
||||
|
||||
export const listingsApi = {
|
||||
create: (data: CreateListingPayload) =>
|
||||
apiClient.post<{ listingId: string; propertyId: string; status: string }>(
|
||||
@@ -192,6 +194,12 @@ export const listingsApi = {
|
||||
data,
|
||||
),
|
||||
|
||||
update: (id: string, data: UpdateListingPayload) =>
|
||||
apiClient.patch<{ listingId: string; propertyId: string; status: string }>(
|
||||
`/listings/${id}`,
|
||||
data,
|
||||
),
|
||||
|
||||
delete: (id: string) =>
|
||||
apiClient.delete<{ success: boolean }>(`/listings/${id}`),
|
||||
|
||||
|
||||
Reference in New Issue
Block a user