feat(auth): complete MFA grace period for required roles + ops monitoring
Finishes the half-implemented MFA enforcement work and ships the SLO
monitoring rules at the same time.
MFA grace period (auth):
- New `mfa-policy.ts` central source of truth: `MFA_REQUIRED_ROLES = [ADMIN]`,
`MFA_GRACE_PERIOD_DAYS = 14`, `MFA_REAUTH_WINDOW_MINUTES = 15`.
- New columns `User.mfaGraceStartedAt` + `User.mfaLastVerifiedAt`
(migration `20260429000000_add_mfa_grace_columns`).
- `JwtPayload.mfa: 'none' | 'grace' | 'enrollment_required'` claim now
carried in every access token so the FE + admin guards can react.
- `LoginUserHandler.resolveMfaGraceClaim()`:
* If role requires MFA and user has not enrolled, lazy-stamp
`mfaGraceStartedAt` on first login (returns `mfa: 'grace'`,
`remainingDays: 14`).
* After window expires → `mfa: 'enrollment_required'`, `remainingDays: 0`
(callers must force enrolment on sensitive routes).
* Otherwise → `mfa: 'none'`.
- `LocalStrategy` now passes `totpEnabled` + `mfaGraceStartedAt` through
to the command so the handler can branch without an extra query.
- `IUserRepository` + `PrismaUserRepository` get
`updateMfaGraceStartedAt` / `updateMfaLastVerifiedAt`.
- `UserEntity` carries the two new fields end-to-end (props, getters,
`createNew` + `createPasswordless` factories). Fixed an orphan-property
syntax bug in `createPasswordless` that was breaking typecheck.
- `oauth.service.ts` `UserEntity` construction now includes `deletedAt`
+ the two MFA fields (was missing required props).
- Add missing `jsonwebtoken` + `@types/jsonwebtoken` to `apps/api`
(transitively pulled in via `jwt-rotation.ts` from commit 3705193 but
never declared, so `tsc --noEmit` was failing).
- Update `login-user.handler.spec.ts` + `local.strategy.spec.ts` to cover
grace-window + enrolment-required branches. 338/338 auth tests pass.
Ops monitoring:
- New `monitoring/prometheus/slo-rules.yml` with recording + alerting
rules for the agreed SLOs.
- Wire it into `prometheus.yml` + alertmanager routing.
- Capture the SLO soak-test results in
`docs/audits/slo-soak-test-log.md`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -31,6 +31,17 @@ route:
|
||||
repeat_interval: 4h
|
||||
|
||||
routes:
|
||||
# Staging SLO soak — burn-rate alerts to Slack only, no pager
|
||||
- matchers:
|
||||
- environment = staging
|
||||
- slo_type =~ "availability|latency"
|
||||
receiver: 'slack-sre-staging-soak'
|
||||
group_by: ['alertname', 'route', 'burn_window']
|
||||
group_wait: 15s
|
||||
group_interval: 5m
|
||||
repeat_interval: 30m
|
||||
continue: false
|
||||
|
||||
# Critical alerts — immediate notification, shorter repeat
|
||||
- matchers:
|
||||
- severity = critical
|
||||
@@ -77,6 +88,17 @@ receivers:
|
||||
{{ if .Annotations.runbook_url }}*Runbook:* {{ .Annotations.runbook_url }}{{ end }}
|
||||
{{ end }}
|
||||
|
||||
- name: 'slack-sre-staging-soak'
|
||||
slack_configs:
|
||||
- channel: '#sre-staging-soak'
|
||||
send_resolved: true
|
||||
title: 'SOAK {{ .CommonLabels.alertname }}'
|
||||
text: >-
|
||||
Route: {{ .CommonLabels.method }} {{ .CommonLabels.route }}
|
||||
Burn: {{ .CommonLabels.burn_window }} | {{ .CommonLabels.severity }}
|
||||
{{ range .Alerts }}{{ .Annotations.summary }}{{ end }}
|
||||
Staging soak — NOT paging.
|
||||
|
||||
- name: 'slack-infrastructure'
|
||||
slack_configs:
|
||||
- channel: '#infrastructure'
|
||||
|
||||
Reference in New Issue
Block a user