fix: valuation page Vietnamese diacritics, correct API routes, update tests

- Add proper Vietnamese diacritics to all valuation components
  (form, results, history) and their test assertions
- Fix valuation API client to use /analytics/valuation endpoint
- Return empty history gracefully (no server endpoint yet)

Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ho Ngoc Hai
2026-04-13 12:03:47 +07:00
parent f373f7b1e2
commit ccfc176e40
8 changed files with 108 additions and 99 deletions

View File

@@ -43,7 +43,7 @@ const mockResult: ValuationResult = {
describe('ValuationResults', () => {
it('renders estimated price', () => {
render(<ValuationResults result={mockResult} />);
expect(screen.getByText('5.00 ty VND')).toBeInTheDocument();
expect(screen.getByText('5.00 t VNĐ')).toBeInTheDocument();
});
it('renders confidence percentage', () => {
@@ -53,17 +53,17 @@ describe('ValuationResults', () => {
it('renders price per m2', () => {
render(<ValuationResults result={mockResult} />);
expect(screen.getByText('62.5 tr/m2')).toBeInTheDocument();
expect(screen.getByText('62.5 tr/m²')).toBeInTheDocument();
});
it('renders price range', () => {
render(<ValuationResults result={mockResult} />);
expect(screen.getByText(/4\.50 ty.*5\.50 ty/)).toBeInTheDocument();
expect(screen.getByText(/4\.50 t.*5\.50 t/)).toBeInTheDocument();
});
it('renders price drivers section', () => {
render(<ValuationResults result={mockResult} />);
expect(screen.getByText('Yeu to anh huong gia')).toBeInTheDocument();
expect(screen.getByText('Yếu tố ảnh hưởng giá')).toBeInTheDocument();
expect(screen.getByText('Vị trí trung tâm')).toBeInTheDocument();
expect(screen.getByText('Tầng thấp')).toBeInTheDocument();
});
@@ -80,31 +80,31 @@ describe('ValuationResults', () => {
it('renders comparables section', () => {
render(<ValuationResults result={mockResult} />);
expect(screen.getByText('Bat dong san tuong tu')).toBeInTheDocument();
expect(screen.getByText('Bt động sn tương t')).toBeInTheDocument();
expect(screen.getByText('Căn hộ tương tự A')).toBeInTheDocument();
expect(screen.getByText('Căn hộ tương tự B')).toBeInTheDocument();
});
it('shows comparable count', () => {
render(<ValuationResults result={mockResult} />);
expect(screen.getByText(/2 bat dong san/)).toBeInTheDocument();
expect(screen.getByText(/2 bt động sn/)).toBeInTheDocument();
});
it('shows similarity percentage for comparables', () => {
render(<ValuationResults result={mockResult} />);
expect(screen.getByText('92% tuong tu')).toBeInTheDocument();
expect(screen.getByText('85% tuong tu')).toBeInTheDocument();
expect(screen.getByText('92% tương t')).toBeInTheDocument();
expect(screen.getByText('85% tương t')).toBeInTheDocument();
});
it('hides drivers section when empty', () => {
const noDrivers = { ...mockResult, priceDrivers: [] };
render(<ValuationResults result={noDrivers} />);
expect(screen.queryByText('Yeu to anh huong gia')).not.toBeInTheDocument();
expect(screen.queryByText('Yếu tố ảnh hưởng giá')).not.toBeInTheDocument();
});
it('hides comparables section when empty', () => {
const noComps = { ...mockResult, comparables: [] };
render(<ValuationResults result={noComps} />);
expect(screen.queryByText('Bat dong san tuong tu')).not.toBeInTheDocument();
expect(screen.queryByText('Bt động sn tương t')).not.toBeInTheDocument();
});
});