Security (P0-5): - Implement ITenantProvider + HttpContextTenantProvider per service (order, fnb, inventory, catalog, wallet) - Add EF Core global query filters for tenant isolation (shop_id/user_id based) - Add TenantMiddleware setting PostgreSQL session variables for RLS - Create PostgreSQL RLS policies script (scripts/db/rls-policies.sql) - Adapter pattern bridges API-layer to Infrastructure-layer (Clean Architecture) - Bypass mechanisms for admin roles, service-to-service calls, and migrations Testing (P1-12): - Add 96 unit tests for fnb-engine (up from 3) - 57 domain entity tests: Table(18), KitchenTicket(12), Session(8), Reservation(13), Recipe(6) - 39 command handler tests: CRUD operations, status transitions, validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
109 lines
3.7 KiB
C#
109 lines
3.7 KiB
C#
using FluentAssertions;
|
|
using FnbEngine.API.Application.Commands;
|
|
using FnbEngine.Domain.AggregatesModel.SessionAggregate;
|
|
using FnbEngine.Domain.AggregatesModel.TableAggregate;
|
|
using FnbEngine.Domain.SeedWork;
|
|
using Microsoft.Extensions.Logging;
|
|
using Moq;
|
|
using Xunit;
|
|
|
|
namespace FnbEngine.UnitTests.Application.Commands;
|
|
|
|
/// <summary>
|
|
/// EN: Unit tests for CloseSessionCommandHandler.
|
|
/// VI: Unit tests cho CloseSessionCommandHandler.
|
|
/// </summary>
|
|
public class CloseSessionCommandHandlerTests
|
|
{
|
|
private readonly Mock<ISessionRepository> _sessionRepoMock;
|
|
private readonly Mock<ITableRepository> _tableRepoMock;
|
|
private readonly Mock<ILogger<CloseSessionCommandHandler>> _loggerMock;
|
|
private readonly CloseSessionCommandHandler _handler;
|
|
|
|
public CloseSessionCommandHandlerTests()
|
|
{
|
|
_sessionRepoMock = new Mock<ISessionRepository>();
|
|
_tableRepoMock = new Mock<ITableRepository>();
|
|
_loggerMock = new Mock<ILogger<CloseSessionCommandHandler>>();
|
|
|
|
_sessionRepoMock.Setup(r => r.UnitOfWork.SaveEntitiesAsync(It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(true);
|
|
|
|
_handler = new CloseSessionCommandHandler(
|
|
_sessionRepoMock.Object,
|
|
_tableRepoMock.Object,
|
|
_loggerMock.Object);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_WithValidSession_ShouldCloseSessionAndFreeTable()
|
|
{
|
|
// Arrange
|
|
var shopId = Guid.NewGuid();
|
|
var tableId = Guid.NewGuid();
|
|
var session = new Session(tableId, shopId, 2);
|
|
var table = new Table(shopId, "A-01", 4);
|
|
table.MarkAsOccupied();
|
|
|
|
_sessionRepoMock.Setup(r => r.GetByIdAsync(session.Id, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(session);
|
|
_tableRepoMock.Setup(r => r.GetByIdAsync(tableId, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(table);
|
|
|
|
var command = new CloseSessionCommand(session.Id);
|
|
|
|
// Act
|
|
var result = await _handler.Handle(command, CancellationToken.None);
|
|
|
|
// Assert
|
|
result.Should().BeTrue();
|
|
session.Status.Should().Be("Closed");
|
|
session.ClosedAt.Should().NotBeNull();
|
|
table.Status.Should().Be(TableStatus.Available);
|
|
_sessionRepoMock.Verify(r => r.Update(session), Times.Once);
|
|
_tableRepoMock.Verify(r => r.Update(table), Times.Once);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_WithNonExistentSession_ShouldThrowInvalidOperationException()
|
|
{
|
|
// Arrange
|
|
var sessionId = Guid.NewGuid();
|
|
_sessionRepoMock.Setup(r => r.GetByIdAsync(sessionId, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync((Session?)null);
|
|
|
|
var command = new CloseSessionCommand(sessionId);
|
|
|
|
// Act
|
|
var action = () => _handler.Handle(command, CancellationToken.None);
|
|
|
|
// Assert
|
|
await action.Should().ThrowAsync<InvalidOperationException>()
|
|
.WithMessage($"*{sessionId}*not found*");
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_WhenTableNotFound_ShouldStillCloseSession()
|
|
{
|
|
// Arrange
|
|
var shopId = Guid.NewGuid();
|
|
var tableId = Guid.NewGuid();
|
|
var session = new Session(tableId, shopId, 2);
|
|
|
|
_sessionRepoMock.Setup(r => r.GetByIdAsync(session.Id, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(session);
|
|
_tableRepoMock.Setup(r => r.GetByIdAsync(tableId, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync((Table?)null);
|
|
|
|
var command = new CloseSessionCommand(session.Id);
|
|
|
|
// Act
|
|
var result = await _handler.Handle(command, CancellationToken.None);
|
|
|
|
// Assert
|
|
result.Should().BeTrue();
|
|
session.Status.Should().Be("Closed");
|
|
_tableRepoMock.Verify(r => r.Update(It.IsAny<Table>()), Times.Never);
|
|
}
|
|
}
|