admin/goodgo-platform
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(web): resolve all 22 TypeScript typecheck errors in apps/web (TEC-3208)

Browse Source 
- Fix TS4111: use bracket notation for index signature access in metadata.spec.ts,
  neighborhood-poi-map.tsx, and neighborhood-poi-map.spec.tsx
- Fix TS2740: add missing property fields (usableAreaM2, floor, totalFloors,
  nearbyPOIs, etc.) to test mock objects in 5 spec files
- Fix TS2339: add missing estimate() and create() methods to transferApi
- Fix TS4114: add override modifier to render() in page.tsx error boundary
- Fix TS2532: add optional chaining for possibly undefined features in
  neighborhood-poi-map.tsx

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Ho Ngoc Hai
2026-04-22 15:49:38 +07:00
parent 566ad75c0e
commit 1668c800fe
10 changed files with 97 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
apps/web/app/[locale]/(public)/listings/[id]/__tests__/metadata.spec.ts
View File

@@ -119,17 +119,17 @@ describe('listing page generateMetadata', () => {
expect(meta.alternates?.languages?.en).toMatch(/\/en\/listings\/listing-1$/);
const og = meta.openGraph as Record<string, unknown>;
expect(og.type).toBe('article');
expect(og.locale).toBe('vi_VN');
expect(og.siteName).toBe('GoodGo');
const ogImages = og.images as Array<{ url: string; width: number; height: number }>;
expect(og['type']).toBe('article');
expect(og['locale']).toBe('vi_VN');
expect(og['siteName']).toBe('GoodGo');
const ogImages = og['images'] as Array<{ url: string; width: number; height: number }>;
expect(ogImages[0]?.url).toBe('https://cdn.example.com/img1.jpg');
expect(ogImages[0]?.width).toBe(1200);
expect(ogImages[0]?.height).toBe(630);
const twitter = meta.twitter as Record<string, unknown>;
expect(twitter.card).toBe('summary_large_image');
expect((twitter.images as string[])[0]).toBe('https://cdn.example.com/img1.jpg');
expect(twitter['card']).toBe('summary_large_image');
expect((twitter['images'] as string[])[0]).toBe('https://cdn.example.com/img1.jpg');
expect(meta.other?.['og:price:currency']).toBe('VND');
expect(meta.other?.['og:price:amount']).toBe('3500000000');
@@ -146,8 +146,8 @@ describe('listing page generateMetadata', () => {
});
const og = meta.openGraph as Record<string, unknown>;
expect(og.locale).toBe('en_US');
const ogImages = og.images as Array<{ url: string }>;
expect(og['locale']).toBe('en_US');
const ogImages = og['images'] as Array<{ url: string }>;
expect(ogImages[0]?.url).toBe('/og-image.png');
});
});

2
apps/web/app/[locale]/(public)/page.tsx
View File

@@ -71,7 +71,7 @@ class SectionErrorBoundary extends React.Component<
return { hasError: true };
}
render() {
override render() {
if (this.state.hasError) {
return (
<div className="flex items-center gap-2 rounded-md border border-border bg-background-surface p-4 text-sm text-foreground-muted">

14
apps/web/components/comparison/__tests__/comparison-table.spec.tsx
View File

@@ -102,6 +102,20 @@ function makeListing(id: string, overrides: Partial<ListingDetail> = {}): Listin
latitude: null,
longitude: null,
media: [{ id: 'm1', type: 'image', url: 'https://example.com/img.jpg', order: 0, caption: null }],
usableAreaM2: null,
floor: null,
totalFloors: null,
nearbyPOIs: null,
metroDistanceM: null,
furnishing: null,
propertyCondition: null,
balconyDirection: null,
maintenanceFeeVND: null,
parkingSlots: null,
viewType: [],
petFriendly: null,
suitableFor: [],
whyThisLocation: null,
},
seller: { id: 's1', fullName: 'Seller', phone: '0901234567' },
agent: null,

2
apps/web/components/neighborhood/__tests__/neighborhood-poi-map.spec.tsx
View File

@@ -228,7 +228,7 @@ describe('NeighborhoodPOIMap', () => {
expect(capturedData).not.toBeNull();
expect(capturedData!.features).toHaveLength(2);
expect(capturedData!.features.map((f) => f.properties?.category)).not.toContain('school');
expect(capturedData!.features.map((f) => f.properties?.['category'])).not.toContain('school');
});
// ── Loading state ─────────────────────────────────────────────────────────────

8
apps/web/components/neighborhood/neighborhood-poi-map.tsx
View File

@@ -264,12 +264,12 @@ export function NeighborhoodPOIMap({
map.on('click', LAYER_CLUSTERS, (e) => {
const features = map.queryRenderedFeatures(e.point, { layers: [LAYER_CLUSTERS] });
if (!features.length) return;
const clusterId = features[0].properties?.cluster_id as number;
const clusterId = features[0]?.properties?.['cluster_id'] as number;
(map.getSource(SOURCE_ID) as mapboxgl.GeoJSONSource).getClusterExpansionZoom(
clusterId,
(err, expansionZoom) => {
if (err || expansionZoom == null) return;
const coords = (features[0].geometry as GeoJSON.Point).coordinates as [number, number];
const coords = (features[0]?.geometry as GeoJSON.Point).coordinates as [number, number];
map.easeTo({ center: coords, zoom: expansionZoom });
},
);
@@ -279,8 +279,8 @@ export function NeighborhoodPOIMap({
map.on('click', LAYER_UNCLUSTERED, (e) => {
const features = map.queryRenderedFeatures(e.point, { layers: [LAYER_UNCLUSTERED] });
if (!features.length) return;
const { name, categoryLabel, distance } = features[0].properties ?? {};
const coords = (features[0].geometry as GeoJSON.Point).coordinates.slice() as [
const { name, categoryLabel, distance } = features[0]?.properties ?? {};
const coords = (features[0]?.geometry as GeoJSON.Point).coordinates.slice() as [
number,
number,
];

14
apps/web/components/search/__tests__/property-card.spec.tsx
View File

@@ -70,6 +70,20 @@ function makeListing(overrides: Partial<ListingDetail> = {}): ListingDetail {
{ id: 'media-1', type: 'image', url: 'https://example.com/img1.jpg', order: 0, caption: null },
{ id: 'media-2', type: 'image', url: 'https://example.com/img2.jpg', order: 1, caption: null },
],
usableAreaM2: null,
floor: null,
totalFloors: null,
nearbyPOIs: null,
metroDistanceM: null,
furnishing: null,
propertyCondition: null,
balconyDirection: null,
maintenanceFeeVND: null,
parkingSlots: null,
viewType: [],
petFriendly: null,
suitableFor: [],
whyThisLocation: null,
},
seller: {
id: 'seller-1',

14
apps/web/components/search/__tests__/search-results.spec.tsx
View File

@@ -49,6 +49,20 @@ function makeListing(id: string): ListingDetail {
latitude: null,
longitude: null,
media: [],
usableAreaM2: null,
floor: null,
totalFloors: null,
nearbyPOIs: null,
metroDistanceM: null,
furnishing: null,
propertyCondition: null,
balconyDirection: null,
maintenanceFeeVND: null,
parkingSlots: null,
viewType: [],
petFriendly: null,
suitableFor: [],
whyThisLocation: null,
},
seller: { id: 's1', fullName: 'Seller', phone: '0901234567' },
agent: null,

14
apps/web/components/seo/__tests__/json-ld.spec.tsx
View File

@@ -126,6 +126,20 @@ describe('generateListingJsonLd', () => {
latitude: 10.73,
longitude: 106.72,
media: [{ id: 'media-1', type: 'image', url: 'https://example.com/img1.jpg', order: 0, caption: null }],
usableAreaM2: null,
floor: null,
totalFloors: null,
nearbyPOIs: null,
metroDistanceM: null,
furnishing: null,
propertyCondition: null,
balconyDirection: null,
maintenanceFeeVND: null,
parkingSlots: null,
viewType: [],
petFriendly: null,
suitableFor: [],
whyThisLocation: null,
},
seller: { id: 'seller-1', fullName: 'Seller', phone: '0912345678' },
agent: null,

14
apps/web/lib/__tests__/comparison-store.spec.ts
View File

@@ -262,6 +262,20 @@ function makeListing(
latitude: null,
longitude: null,
media: [],
usableAreaM2: null,
floor: null,
totalFloors: null,
nearbyPOIs: null,
metroDistanceM: null,
furnishing: null,
propertyCondition: null,
balconyDirection: null,
maintenanceFeeVND: null,
parkingSlots: null,
viewType: [],
petFriendly: null,
suitableFor: [],
whyThisLocation: null,
},
seller: {
id: 'seller-1',

13
apps/web/lib/chuyen-nhuong-api.ts
View File

@@ -8,6 +8,7 @@ import {
type LucideIcon,
} from 'lucide-react';
import { apiClient } from './api-client';
import type { AiEstimateResult } from './transfer-wizard-store';
// ─── Types ──────────────────────────────────────────────
@@ -185,4 +186,16 @@ export const transferApi = {
getStats: () =>
apiClient.get<TransferStats>('/transfer/stats'),
estimate: (payload: { category: TransferCategory; condition: TransferCondition; originalPriceVND: number; purchaseYear: number }[]) =>
apiClient.post<AiEstimateResult>(
'/transfer/estimate',
payload,
),
create: (payload: Record<string, unknown>) =>
apiClient.post<{ listingId: string; status: string }>(
'/transfer/listings',
payload,
),
};