refactor(web): replace emoji icons with lucide-react across the app
Some checks failed
Deploy / Build API Image (push) Failing after 19s
Deploy / Build Web Image (push) Failing after 11s
Security Scanning / Trivy Filesystem Scan (push) Failing after 27s
Deploy / Deploy to Staging (push) Has been skipped
Deploy / Smoke Test Production (push) Has been skipped
Deploy / Deploy to Production (push) Has been skipped
CI / Lint → Typecheck → Test → Build (22) (push) Failing after 11s
CI / E2E Tests (push) Has been skipped
CodeQL Analysis / CodeQL (javascript-typescript) (push) Failing after 37s
Deploy / Build AI Services Image (push) Failing after 10s
E2E Tests / Playwright E2E (push) Failing after 10s
Security Scanning / Dependency Audit (pnpm) (push) Failing after 3s
Security Scanning / Trivy Scan — API Image (push) Failing after 47s
Security Scanning / Trivy Scan — Web Image (push) Failing after 31s
Security Scanning / Trivy Scan — AI Services Image (push) Failing after 32s
Deploy / Smoke Test Staging (push) Has been skipped
Security Scanning / Security Gate (push) Failing after 1s
Deploy / Rollback Staging (push) Has been skipped
Deploy / Rollback Production (push) Has been skipped

User directive: avoid emojis for UI chrome; keep the icon language
consistent with the rest of the design system (shadcn + lucide-react).

Swaps
-----
- lib/listing-personas.ts — Persona emojis (👨‍👩‍👧🏡🚇🧑‍💻🌳📈🛡️🏥)
  → Lucide icons (Baby, Home, TrainFront, Laptop, Trees, TrendingUp,
  Shield, HeartPulse). Persona type now carries `icon: LucideIcon`.
- components/neighborhood/types.ts — POI_CATEGORY_CONFIG emojis
  (🏫🏥🚇🛒🍽️🌳) → Lucide (GraduationCap, Stethoscope, TrainFront,
  ShoppingBag, UtensilsCrossed, Trees). Config type tightened to
  `icon: LucideIcon`.
- components/neighborhood/neighborhood-poi-map.tsx — filter pills
  now render <config.icon h-3.5 w-3.5>. Map markers were text-emoji
  (el.textContent = config.icon); replaced with hard-coded inline
  SVG strings per category (POI_MARKER_SVG) since lucide-static
  isn't installed. Marker bumped 28px → 32px for larger hit target.
  Popup now shows only the property name + category label (no
  emoji prefix). closeButton: true + closeOnClick: true for
  better dismissibility.
- listing-detail-client.tsx — PersonaFitCard now renders
  <p.icon h-4 w-4 aria-hidden>.
- transfer / chuyen-nhuong files — category icons (🛋️🧊🖥️🍳🛍️🏠)
  migrated to Lucide (Sofa, Refrigerator, Monitor, ChefHat, Store,
  Home) with type `icon: LucideIcon`.
- Small replacements: inquiries page 📭 → Inbox; kyc page ✓ → Check.

POI popup click fix
-------------------
The inner SVG inside each POI marker was capturing pointer events
before Mapbox's marker-click handler saw them, so clicking a marker
did nothing. Explicit `innerSvg.style.pointerEvents = 'none'` lets
clicks reach the wrapping .poi-marker div that setPopup() is bound
to. Verified via DOM dispatch: click → popup opens with property
name + category + distance + × close.

Verification
------------
- Grep across the 4 scoped files for emoji code points → 0 hits.
- pnpm -w test: 624/624 green.
- Typecheck: no new errors in touched files.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ho Ngoc Hai
2026-04-19 16:01:13 +07:00
parent 88429a1e51
commit 593d1594bd
13 changed files with 149 additions and 63 deletions

View File

@@ -7,6 +7,17 @@
* once we have a `suitableFor` / `whyThisLocation` column (Phase B).
*/
import {
Baby,
HeartPulse,
Home,
Laptop,
Shield,
TrainFront,
Trees,
TrendingUp,
type LucideIcon,
} from 'lucide-react';
import type { NearbyPOICategory } from './analytics-api';
import type { ListingDetail, NeighborhoodScoreResult } from './listings-api';
@@ -23,19 +34,19 @@ export type PersonaKey =
export interface Persona {
key: PersonaKey;
label: string;
emoji: string;
icon: LucideIcon;
reason: string;
}
const PERSONA_LABELS: Record<PersonaKey, { label: string; emoji: string }> = {
family_with_kids: { label: 'Gia đình có con nhỏ', emoji: '👨‍👩‍👧' },
young_family: { label: 'Gia đình trẻ', emoji: '🏡' },
commuter: { label: 'Người đi làm xa', emoji: '🚇' },
single_young: { label: 'Người trẻ / độc thân', emoji: '🧑‍💻' },
nature_lover: { label: 'Yêu thiên nhiên', emoji: '🌳' },
investor: { label: 'Nhà đầu tư', emoji: '📈' },
safety_first: { label: 'Ưu tiên an ninh', emoji: '🛡️' },
senior: { label: 'Người lớn tuổi', emoji: '🏥' },
const PERSONA_LABELS: Record<PersonaKey, { label: string; icon: LucideIcon }> = {
family_with_kids: { label: 'Gia đình có con nhỏ', icon: Baby },
young_family: { label: 'Gia đình trẻ', icon: Home },
commuter: { label: 'Người đi làm xa', icon: TrainFront },
single_young: { label: 'Người trẻ / độc thân', icon: Laptop },
nature_lover: { label: 'Yêu thiên nhiên', icon: Trees },
investor: { label: 'Nhà đầu tư', icon: TrendingUp },
safety_first: { label: 'Ưu tiên an ninh', icon: Shield },
senior: { label: 'Người lớn tuổi', icon: HeartPulse },
};
type POICountByCategory = Partial<Record<NearbyPOICategory, number>>;