feat(avm): end-to-end AVM v2 schema + POST /analytics/valuation endpoint
Some checks failed
CodeQL Analysis / CodeQL (javascript-typescript) (push) Failing after 1m31s
Deploy / Build API Image (push) Failing after 25s
E2E Tests / Playwright E2E (push) Failing after 23s
Security Scanning / Dependency Audit (pnpm) (push) Failing after 6s
Deploy / Build Web Image (push) Failing after 17s
Deploy / Build AI Services Image (push) Failing after 13s
Security Scanning / Trivy Scan — Web Image (push) Failing after 58s
Security Scanning / Trivy Scan — AI Services Image (push) Failing after 51s
Security Scanning / Trivy Scan — API Image (push) Failing after 1m55s
Security Scanning / Trivy Filesystem Scan (push) Failing after 45s
Deploy / Deploy to Staging (push) Has been skipped
Deploy / Smoke Test Staging (push) Has been skipped
Deploy / Deploy to Production (push) Has been skipped
Deploy / Smoke Test Production (push) Has been skipped
Security Scanning / Security Gate (push) Failing after 3s
Deploy / Rollback Staging (push) Has been skipped
Deploy / Rollback Production (push) Has been skipped
CI / Lint → Typecheck → Test → Build (22) (push) Failing after 8s
CI / E2E Tests (push) Has been skipped

Closes the last gap from the tec-2725 branch: the valuation form's v2
extended-features section and POST endpoint can now submit real
predictions through to the Python ensemble model.

Backend
- New DTO apps/api/src/modules/analytics/presentation/dto/predict-valuation.dto.ts
  with all v1 fields + 8 v2 fields (useV2 toggle, distanceToHospital/Park/
  Mall in km, floodZoneRisk enum NONE|LOW|MEDIUM|HIGH, hasElevator/
  Parking/Pool booleans).
- New CQRS handler apps/api/src/modules/analytics/application/queries/
  predict-valuation/ that routes to AVM_SERVICE.estimateValue() with the
  full request body.
- Extend AVMParams (domain) with the same v2 fields + inline v1 fields
  (district, city, bedrooms, bathrooms, floors, frontage, roadWidth,
  hasLegalPaper, projectId, imageUrl, description, deepAnalysis).
- HttpAVMService.estimateViaAi now branches on `useV2`: v2 calls the new
  aiClient.predictV2() → POST /avm/v2/predict on the Python service,
  mapping floodZoneRisk enum → 0..1 float and computing
  building_age_years from yearBuilt. v1 path gets all the inline
  descriptors wired through so non-propertyId calls no longer lose
  context.
- AiServiceClient gets AiPredictV2Request / AiPredictV2Response types
  mirroring libs/ai-services/app/models/avm_v2.py::AVMv2PredictRequest
  (which already accepts all 7 numeric/boolean v2 fields — no Python
  change needed).
- Register PredictValuationHandler in AnalyticsModule.
- New route POST /analytics/valuation on AnalyticsController:
  JwtAuthGuard + QuotaGuard + EndpointRateLimitGuard (10/min),
  @RequireQuota('analytics_queries'), full Swagger doc. Total endpoint
  count 179 → 180.

Frontend
- Extend ValuationRequest with useV2, 3 distance-km fields,
  floodZoneRisk, hasElevator/Parking/Pool + export FloodZoneRisk type
  and FLOOD_RISK_OPTIONS.
- valuationApi.predict() body mapping now includes v2 fields and renames
  'areaM2' → 'area' to match the backend DTO contract.
- valuationFormSchema gains matching optional Zod fields + exports
  FLOOD_RISK_OPTIONS for the form.
- valuation-form.tsx gets:
  * Image upload hardening: MIME+size validation (JPG/PNG ≤5MB) before
    preview, role="progressbar" + aria-labels on the progress bar,
    role="alert" + data-testid="image-upload-error" on errors. Matches
    the upload-progress part of the task/tec-2725 commit 4ee0129 that
    was previously parked as blocked.
  * New Sparkles-branded "Mô hình v2 (Ensemble)" toggle alongside the
    existing Bot-branded "Phân tích chuyên sâu" toggle.
  * Collapsible "Đặc trưng mở rộng (AVM v2)" section with distance
    inputs, flood-risk select, and three amenity checkboxes.
  * handleFormSubmit passes all v2 fields through to onSubmit.

Python service unchanged — AVMv2PredictRequest already has every field
we send (distance_to_hospital_km, flood_zone_risk as float,
has_elevator/parking/pool, etc.).

Typecheck clean for the valuation surface. Pre-existing errors in
metadata.spec.ts and transfer-wizard-client.tsx are unrelated and left
for a follow-up.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ho Ngoc Hai
2026-04-19 06:49:57 +07:00
parent 58b0e6ba12
commit 79e173938b
12 changed files with 736 additions and 19 deletions

View File

@@ -15,6 +15,13 @@ export const CITIES = [
{ value: 'Da Nang', label: 'Đà Nẵng' },
] as const;
export const FLOOD_RISK_OPTIONS = [
{ value: 'NONE', label: 'Không có' },
{ value: 'LOW', label: 'Thấp' },
{ value: 'MEDIUM', label: 'Trung bình' },
{ value: 'HIGH', label: 'Cao' },
] as const;
export const valuationFormSchema = z.object({
propertyType: z.string().min(1, 'Vui lòng chọn loại bất động sản'),
area: z.string().min(1, 'Vui lòng nhập diện tích').refine(
@@ -34,6 +41,15 @@ export const valuationFormSchema = z.object({
projectId: z.string().optional(),
description: z.string().optional(),
deepAnalysis: z.boolean().optional(),
/** AVM v2 fields */
useV2: z.boolean().optional(),
distanceToHospitalKm: z.string().optional(),
distanceToParkKm: z.string().optional(),
distanceToMallKm: z.string().optional(),
floodZoneRisk: z.enum(['NONE', 'LOW', 'MEDIUM', 'HIGH']).optional(),
hasElevator: z.boolean().optional(),
hasParking: z.boolean().optional(),
hasPool: z.boolean().optional(),
});
export type ValuationFormData = z.infer<typeof valuationFormSchema>;

View File

@@ -2,6 +2,15 @@ import { apiClient } from './api-client';
// ─── Types ──────────────────────────────────────────────
export type FloodZoneRisk = 'NONE' | 'LOW' | 'MEDIUM' | 'HIGH';
export const FLOOD_RISK_OPTIONS: { value: FloodZoneRisk; label: string }[] = [
{ value: 'NONE', label: 'Không có' },
{ value: 'LOW', label: 'Thấp' },
{ value: 'MEDIUM', label: 'Trung bình' },
{ value: 'HIGH', label: 'Cao' },
];
export interface ValuationRequest {
propertyType: string;
area: number;
@@ -24,6 +33,15 @@ export interface ValuationRequest {
description?: string;
/** Request deep analysis (confidence explanation, more drivers) */
deepAnalysis?: boolean;
/** Use AVM v2 ensemble model (extended features) */
useV2?: boolean;
distanceToHospitalKm?: number;
distanceToParkKm?: number;
distanceToMallKm?: number;
floodZoneRisk?: FloodZoneRisk;
hasElevator?: boolean;
hasParking?: boolean;
hasPool?: boolean;
}
export interface ValuationComparable {
@@ -157,10 +175,9 @@ export interface ProjectSuggestion {
export const valuationApi = {
/** Request AVM estimate via POST /analytics/valuation */
predict: (data: ValuationRequest) => {
// Build request body with all fields
const body: Record<string, unknown> = {
propertyType: data.propertyType,
areaM2: data.area,
area: data.area,
district: data.district,
city: data.city,
};
@@ -179,6 +196,16 @@ export const valuationApi = {
if (data.description) body['description'] = data.description;
if (data.deepAnalysis) body['deepAnalysis'] = data.deepAnalysis;
// AVM v2 fields
if (data.useV2) body['useV2'] = data.useV2;
if (data.distanceToHospitalKm != null) body['distanceToHospitalKm'] = data.distanceToHospitalKm;
if (data.distanceToParkKm != null) body['distanceToParkKm'] = data.distanceToParkKm;
if (data.distanceToMallKm != null) body['distanceToMallKm'] = data.distanceToMallKm;
if (data.floodZoneRisk) body['floodZoneRisk'] = data.floodZoneRisk;
if (data.hasElevator != null) body['hasElevator'] = data.hasElevator;
if (data.hasParking != null) body['hasParking'] = data.hasParking;
if (data.hasPool != null) body['hasPool'] = data.hasPool;
return apiClient.post<ValuationResult>('/analytics/valuation', body);
},